Skip to content

Create deploy-azure-naming-tool-to-azure-webapps-dotnet-core-oidc.yml - #155

Open
Rafael Fernández (rfernandezdo) wants to merge 7 commits into
Azure:mainfrom
rfernandezdo:patch-1
Open

Rafael Fernández (rfernandezdo) wants to merge 7 commits into
Azure:mainfrom
rfernandezdo:patch-1

Conversation

@rfernandezdo

Copy link
Copy Markdown

Pipeline with OIDC

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ololo

Copilot AI review requested due to automatic review settings September 29, 2025 09:29

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a GitHub Actions workflow for deploying a .NET Core Azure Naming Tool application to Azure Web Apps using OpenID Connect (OIDC) authentication. The workflow replaces traditional secret-based authentication with more secure OIDC authentication for Azure deployments.

  • Introduces OIDC-based Azure authentication using client ID, tenant ID, and subscription ID
  • Sets up automated deployment pipeline triggered on pushes to main branch
  • Configures build and deploy jobs with proper artifact handling

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread .github/workflows/deploy-azure-naming-tool-to-azure-webapps-dotnet-core-oidc.yml Outdated
…tnet-core-oidc.yml

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have updated the app to .NET 10. Please update the Action to .NET 10, as well.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The OIDC direction is worthwhile, and the .NET 10 update addresses the earlier feedback. This should not merge as-is, however:

  • Pin every third-party action to a full commit SHA with a version comment, matching the policy established in #210.
  • Resolve the deployment overlap with the existing App Service workflow. Both currently trigger on pushes to main and can target the same AZURE_WEBAPP_NAME, which risks concurrent duplicate production deployments when both credential sets are configured. Prefer replacing/migrating the existing workflow or make the triggers mutually exclusive.
  • Add an early configuration check for the required OIDC and web app values, and clarify whether the GitHub environment is intentionally Production rather than the existing workflow's Development environment.

There are currently no CI checks on this PR, so the revised workflow should also be validated before merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants