Repository navigation
Az.StackHCI | Selectively enable ARC - #22848
Merged
NoriZC merged 1 commit intoSep 25, 2023
Merged
Conversation
️✔️Az.Accounts
|
| Type | Cmdlet | Description | Remediation |
|---|---|---|---|
| Get-AzStackHciArcSetting | Get-AzStackHciArcSetting Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzStackHciArcSetting | Get-AzStackHciArcSetting changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| Get-AzStackHciCluster | Get-AzStackHciCluster Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzStackHciCluster | Get-AzStackHciCluster changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| Get-AzStackHciExtension | Get-AzStackHciExtension Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzStackHciExtension | Get-AzStackHciExtension changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| Get-AzStackHCIRemoteSupportAccess | Get-AzStackHCIRemoteSupportAccess Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzStackHCIRemoteSupportAccess | Get-AzStackHCIRemoteSupportAccess changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| Get-AzStackHCIRemoteSupportSessionHistory | Get-AzStackHCIRemoteSupportSessionHistory Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzStackHCIRemoteSupportSessionHistory | Get-AzStackHCIRemoteSupportSessionHistory changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. |
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
⚠️ File Change Check
⚠️ PowerShell Core - Windows
Type Cmdlet Description Remediation ⚠️ It is required to update ChangeLog.md if you want to release a new version for Az.StackHCI. Add a changelog record under Upcoming Release section with past tense.
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
⚠️ Test
⚠️ - Linux
Type Title Current Coverage Description ⚠️ Test Coverage Less Than 50% 40.74 % Test coverage for the module cannot be lower than 50%.
⚠️ - MacOS
Type Title Current Coverage Description ⚠️ Test Coverage Less Than 50% 40.74% Test coverage for the module cannot be lower than 50%.
⚠️ PowerShell Core - Windows
Type Title Current Coverage Description ⚠️ Test Coverage Less Than 50% 40.74% Test coverage for the module cannot be lower than 50%.
|
|
IndraneelPal
approved these changes
Sep 22, 2023
Contributor
|
Could you provide more details about selectively enable ARC in PR description? Like:
|
|
Adding @prateek ***@***.***> and @niranjan ***@***.***>
Thanks
From: NoriZC ***@***.***>
Sent: Monday, September 25, 2023 11:55 AM
To: Azure/azure-powershell ***@***.***>
Cc: Indraneel Pal ***@***.***>; Comment ***@***.***>
Subject: Re: [Azure/azure-powershell] Az.StackHCI | Selectively enable ARC (PR #22848)
Could you provide more details about selectively enable ARC in PR description? Like:
* Why when Cloud deplyment is enabled, we should skip ARC.
* When Cloud deployment is enabled:
* in which cases should we directly throw an error?
* in which cases should the process been skiipped?
-
Reply to this email directly, view it on GitHub<#22848 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AZEGLDQQVYXZKV63JL6U5NTX4EPS7ANCNFSM6AAAAAA5CZ3KGU>.
You are receiving this because you commented.Message ID: ***@***.******@***.***>>
|
Member
Author
NoriZC, I've updated the description with more details. Please let me know if that looks or you want me to elaborate more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist
CONTRIBUTING.mdand reviewed the following information:generationbranch.ChangeLog.mdfile(s) appropriatelyChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader in the past tense. Add changelog in description section if PR goes intogenerationbranch.ChangeLog.mdif no new release is required, such as fixing test case only.