[Microsoft.Web] Upgrade API version to 2025-05-01 - #30097
Conversation
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
/azp run |
|
Azure Pipelines: Successfully started running 2 pipeline(s). There may be pipelines that require an authorized user to comment /azp run to run. |
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
There was a problem hiding this comment.
🟡 Changes recommended
It introduces a blank row in the breaking-change exceptions CSV and contains literal “\n” sequences in generated XML docs that should be corrected to avoid malformed documentation.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 1/572 changed files
- Comments generated: 2
- Review effort level: Lite
| @@ -1,2 +1,3 @@ | |||
| "Module","ClassName","Target","Severity","ProblemId","Description","Remediation" | |||
| "Az.Websites","Microsoft.Azure.Commands.WebApps.Cmdlets.WebApps.EditAzureWebAppBackupConfiguration","Edit-AzWebAppBackupConfiguration","0","3000","The type of property 'IsPushEnabled' of type 'Microsoft.Azure.Management.WebSites.Models.PushSettings' has changed from 'System.Boolean' to 'System.Nullable`1[System.Boolean]'.","Change the type of property 'IsPushEnabled' back to 'System.Boolean'." | |||
|
|
|||
| /// <param name="ignoreConflictingHostNames">Changes a logic when restoring an app with custom domains. | ||
| /// <code>true</code> to remove custom domains automatically. If | ||
| /// <code>false</code>, custom domains are added to | ||
| /// the app's object when it is being restored, but that might fail due to | ||
| /// conflicts during the operation. | ||
| /// <code>false</code>, custom domains are added to \nthe app's object when it | ||
| /// is being restored, but that might fail due to conflicts during the | ||
| /// operation. |
|
/azp run |
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
There was a problem hiding this comment.
🟡 Changes recommended
It introduces a potentially breaking public API change (ProxyOnlyResource no longer implementing IResource) and includes malformed generated XML docs containing literal \n escape sequences.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
Suppressed comments (1)
Previously missed (1) — in code that hasn't changed since the last review.
src/Websites/Websites.Management.Sdk/Customizations/VnetInfo.cs:19
VnetInfo(VnetInfoResource resource)dereferencesresourcein the base initializer and body without a guard. Adding an explicit null-check makes failures deterministic and avoids a less-informativeNullReferenceExceptionif this constructor is ever called with null.
- Files reviewed: 1/572 changed files
- Comments generated: 1
- Review effort level: Lite
| @@ -11,7 +11,7 @@ namespace Microsoft.Azure.Management.WebSites.Models | |||
| /// Azure proxy only resource. This resource is not tracked by Azure Resource | |||
| /// Manager. | |||
| /// </summary> | |||
| public partial class ProxyOnlyResource : Microsoft.Rest.Azure.IResource | |||
| public partial class ProxyOnlyResource | |||
|
/azp run |
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
🤖 PR Validation — ️✔️ All clear
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.