[Experiment][Compute] Tab completion for New-AzVm - #4655
Merged
Sergey Shandar (sergey-shandar) merged 31 commits intoOct 9, 2017
Merged
Sergey Shandar (sergey-shandar) merged 31 commits into
Sergey Shandar (sergey-shandar) merged 31 commits into
Conversation
Contributor
Author
Contributor
Author
13 tasks
Sergey Shandar (sergey-shandar)
requested a review
from Maddie Clayton (maddieclayton)
September 26, 2017 22:44
Maddie Clayton (maddieclayton)
approved these changes
Sep 27, 2017
Maddie Clayton (maddieclayton)
left a comment
Contributor
There was a problem hiding this comment.
I don't understand what most of the changes are doing, but the Register-ArgumentCompleter code looks good to me.
Member
|
Sergey Shandar (@sergey-shandar) did not get a chance to update the preview branch with this, will review on return. |
Mark Cowlishaw (markcowl)
requested changes
Oct 6, 2017
| New-AzVm -Name MyVM -Credential $vmCredential -WhatIf | ||
| } | ||
| It 'Create Windows VM' { | ||
| New-AzVm -Name MyVMA1 -Credential $vmCredential -ResourceGroupName Something1 -Verbose |
There was a problem hiding this comment.
I think we should pair this with some validations, like validating the output of the cmdlet, and perhaps performing a Get and verifying proeprties for the expected resources.
| # Modules that must be imported into the global environment prior to importing this module | ||
| RequiredModules = @( | ||
| @{ ModuleName = "AzureRM.Resources"; ModuleVersion = "4.3.2"; }, |
There was a problem hiding this comment.
Compute = 3.4.0, Network = 4.4.0, Resources = 4.4.0
This was referenced Oct 9, 2017
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.
General Guidelines
Testing Guidelines
Cmdlet Signature Guidelines
ShouldProcessand haveSupportShouldProcess=truespecified in the cmdlet attribute. You can find more information onShouldProcesshere.OutputTypeattribute if any output is produced - if the cmdlet produces no output, it should implement aPassThruparameter.Cmdlet Parameter Guidelines