[SQL] Port SqlDatabaseBackupShortTermRetentionPolicy preview cmdlets to master - #8376
Merged
Maddie Clayton (maddieclayton) merged 9 commits intoJan 25, 2019
Merged
Maddie Clayton (maddieclayton) merged 9 commits into
Maddie Clayton (maddieclayton) merged 9 commits into
Conversation
Jared Moore (jaredmoo)
suggested changes
Jan 23, 2019
Jared Moore (jaredmoo)
left a comment
Jared Moore (jaredmoo)
left a comment
Contributor
There was a problem hiding this comment.
Aren't there any tests?
Contributor
Author
Jared Moore (@jaredmoo) Yep, |
Jared Moore (jaredmoo)
previously approved these changes
Jan 23, 2019
Cormac McCarthy (cormacpayne)
suggested changes
Jan 23, 2019
Cormac McCarthy (cormacpayne)
left a comment
Cormac McCarthy (cormacpayne)
left a comment
Member
There was a problem hiding this comment.
@dealaus two minor comments, otherwise LGTM
…baseBackupShortTermRetentionPolicy
Austin Deal (adeal)
assigned
Cormac McCarthy (cormacpayne) and unassigned
Austin Deal (adeal)
Austin Deal (adeal)
added
needs-review
and removed
Merge Conflicts
needs-revision
labels
Cormac McCarthy (cormacpayne)
previously approved these changes
Jan 25, 2019
Cormac McCarthy (cormacpayne)
left a comment
Cormac McCarthy (cormacpayne)
left a comment
Member
There was a problem hiding this comment.
LGTM -- this should be merged after the release branch has been merged back into master
Cormac McCarthy (cormacpayne)
approved these changes
Jan 25, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add Get-AzSqlDatabaseBackupShortTermRetentionPolicy and Set-AzSqlDatabaseBackupShortTermRetentionPolicy to master.
These cmdlets have been in Az[ureRM].Sql-preview for >6 months. Moving to stable branch.
NOTE: I am unable to port the applicable tests right now because my MSDN subscription is disabled which prevents me from re-recording tests. I will do this once it is re-enabled. I did manual testing in the interim.Original PR: #6326 (comment)
Addressing issue: https://github.com/MicrosoftDocs/azure-docs/issues/9312#issuecomment-456498276
Checklist
CONTRIBUTING.mdplatyPSmodule