Skip to content

[GuestConfiguration] Supports Audit policies, fixed online doc link for help files - #8387

Merged
Michael Yanni (MiYanni) merged 3 commits into
Azure:Az.GuestConfigurationfrom
viveklingaiah:Az.GuestConfiguration
Jan 28, 2019
Merged

Michael Yanni (MiYanni) merged 3 commits into
Azure:Az.GuestConfigurationfrom
viveklingaiah:Az.GuestConfiguration

Conversation

@viveklingaiah

@viveklingaiah Vivek Lingaiah (viveklingaiah) commented Jan 23, 2019 •

Copy link
Copy Markdown

Description

Checklist

@viveklingaiah

Copy link
Copy Markdown
Author

Michael Yanni (@MiYanni) I'm facing two issues below:

  1. I'm still not able to load help content when I do get-help
  2. when i just copy the GuestConfiguration folde, zip it and unzip it on a different box and try to import module, it throws errors.

@MiYanni

Michael Yanni (MiYanni) commented Jan 24, 2019 •

Copy link
Copy Markdown
Contributor

vivlingaiah

  1. You have to generate the -Help.xml files. When you run the build.proj, include the property, /p:RunStaticAnalysis=true.
  2. Run your fork and branch through this Jenkins project: https://azuresdkci.westus2.cloudapp.azure.com/view/PowerShell/job/psnetsign-esrp/build?delay=0sec
    We publish the module with a completely different set of DLLs than what is used to build the module. This is because we load shared DLLs into the Accounts module, and have all modules take a dependency on Accounts. This way, every module doesn't need to have copies of the same DLLs.
    After that build finishes, share the Az.GuestConfiguration.nupkg and Az.Accounts.nupkg with them. Have them put it into a folder on their machine (like C:\Modules\) and run these commands to register the folder as a module repo and then install the module:
Register-PSRepository -Name GuestConfigurationPreview -SourceLocation {{path to the folder where the nupkg is}} -PackageManagementProvider NuGet -InstallationPolicy Trusted
Install-Module -Name Az.GuestConfiguration -Repository GuestConfigurationPreview

Additionally, are they running Windows PowerShell or PowerShell Core? They'll need .NET Framework 4.7.2 installed if they are using Windows PowerShell. PowerShell Core does not have this dependency.

@viveklingaiah

Copy link
Copy Markdown
Author

Michael Yanni (@MiYanni) ,

  • I have fixed tests in commit 2, because build was failing.
  • I also did include dll-help.xml file anywhere in the commit. Is that the right thing to do ?

@viveklingaiah

Copy link
Copy Markdown
Author

I put the nupkg files together under a dir and imported the module successfully. I'm still getting below the error message:

image

@viveklingaiah

Copy link
Copy Markdown
Author

also help is missing with nupkg. I'm able to access local content in local dev env

@viveklingaiah

Copy link
Copy Markdown
Author

build is also failing due to below error. KustoClusterNotExist wasn't added as part of PR

Properties\Resources.resx : warning MSB3568: Duplicate resource name "KustoClusterNotExist" is not allowed, ignored. [c:\workspace\powershell\src\Kusto\Kusto\Kusto.csproj] [c:\workspace\powershell\build.proj]
EXEC : warning : The names of some imported commands from the module 'HelpGeneration' include unapproved verbs that might make them less discoverable. To find the commands with unapproved verbs, run the Import-Module command again with the Verbose parameter. For a list of approved verbs, type Get-Verb. [c:\workspace\powershell\build.proj]

@viveklingaiah

Copy link
Copy Markdown
Author

FYI. checked with my manager and team. we can go ahead and publish this module as is.

@MiYanni
Michael Yanni (MiYanni) dismissed their stale review January 28, 2019 21:59

Incorrect assessment.

@MiYanni
Michael Yanni (MiYanni) merged commit f3f54c6 into Azure:Az.GuestConfiguration Jan 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants