Skip to content

Azure::Core #683

Closed
Closed

Description

Features

Http (Transports, Adapters, Pipelines)

Identity

Testing, Reliability, Performance

  • Long-running process
  • Leak detection
  • Test coverage improvements #2570
    • Enable code coverage
    • Enable a similar gate for C++ as what we did in C
  • Performance of Track2 should be on par with Track1 (Add issues, GA??)

Tools / Tooling

Guidelines

  • Clarify on when to use RequestFailedException
  • Exception Hierarchy and propagation
  • Consider Spans instead of pointer/length
  • Add Extensible Enum

Process

  • Archboard review
  • Component Governance
    • NOTICE.txt in each package vs root
    • cgmanifest in each package vs root

Documentation & Samples

Activity

  1. changed the title [-]Azure::Core GA[/-] [+]Azure::Core[/+] on Sep 24, 2020
  2. vhvb1989 commented on Nov 3, 2020

    @vhvb1989
    Member
    • Need to move protocol layer to a ::Details namespace
  3. ahsonkhan commented on Dec 9, 2020

    @ahsonkhan
    Contributor

    Add Logging API design update to follow C and remove locks and global state:

    namespace {
    std::mutex g_loggerMutex;
    LogListener g_logListener(nullptr);
    LogClassifications g_logClassifications(
    LogClassificationsPrivate::LogClassificationsConstant(true));
    LogListener GetLogListener(LogClassification const& classification)
    {
    // lock listener and classifications
    std::lock_guard<std::mutex> loggerLock(g_loggerMutex);
    return (!g_logListener // if no logger is set
    || LogClassificationsPrivate::IsClassificationEnabled(
    g_logClassifications, classification))
    // or if classification is enabled
    ? g_logListener // return actual listener (may be null)
    : LogListener(nullptr) // return null listener
    ;
    }
    } // namespace

  4. ahsonkhan commented on May 7, 2021

    @ahsonkhan
    Contributor

    PoliCheck done before GA, on commit 1a71c46, no issues found

  5. locked and limited conversation to collaborators on Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Azure.CoreClientThis issue points to a problem in the data-plane of the library.Epic

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions