Skip to content

Azure CLI upgrade notification prevents token generation on MacOS shells due to TTY validation #36290

Closed
#36553
Closed
Azure CLI upgrade notification prevents token generation on MacOS shells due to TTY validation#36290
#36553
Assignees
g2vinay
Labels
Azure.IdentityClientThis issue points to a problem in the data-plane of the library.bugThis issue requires a change to an existing behavior in the product in order to be resolved.customer-reportedIssues that are reported by GitHub users external to the Azure organization.needs-team-attentionWorkflow: This issue needs attention from Azure service team or SDK team
Milestone
2023-10

Description

@josh-uk
Josh (josh-uk)
opened on Aug 9, 2023

Describe the bug

When trying to generate an access token with AzureCliCredential it will always fail due to the CLI prompt returned by az account get-access-token --output json --resource (IdentityClient.java) will always return the following which requires a user response when Azure CLI is on an unupgraded version:

New Azure CLI version available. Running 'az upgrade' to update automatically.
This command is in preview and under development. Reference and support levels: https://aka.ms/CLI_refstatus
Your current Azure CLI version is 2.44.1. Latest version available is 2.51.0.
Please check the release notes first: https://docs.microsoft.com/cli/azure/release-notes-azure-cli
Do you want to continue? (Y/n):

Note: This is also an issue in 2.50.0 which is the latest available on brew.

Exception or Stack Trace

Exception in thread "main" java.lang.IllegalStateException: com.fasterxml.jackson.core.JsonParseException: Unrecognized token 'WARNING': was expecting (JSON String, Number, Array, Object or token 'null', 'true' or 'false')
 at [Source: (String)"WARNING: New Azure CLI version available. Running 'az upgrade' to update automatically.WARNING: Unable to prompt for auto upgrade as no tty available. Run 'az config set auto-upgrade.prompt=no' to allow auto upgrade with no prompt.{  "accessToken": "REDACTED_ACCESS_TOKEN"[truncated 5149 chars]; line: 1, column: 8]
        at com.azure.identity.implementation.IdentityClientBase.getTokenFromAzureCLIAuthentication(IdentityClientBase.java:562)
        at com.azure.identity.implementation.IdentitySyncClient.authenticateWithAzureCli(IdentitySyncClient.java:343)
        at com.azure.identity.AzureCliCredential.getTokenSync(AzureCliCredential.java:92)
        at com.azure.core.implementation.AccessTokenCache.lambda$new$2(AccessTokenCache.java:62)
        at com.azure.core.implementation.AccessTokenCache.lambda$retrieveTokenSync$9(AccessTokenCache.java:224)
        at com.azure.core.implementation.AccessTokenCache.getTokenSync(AccessTokenCache.java:88)
        at com.azure.core.http.policy.BearerTokenAuthenticationPolicy.setAuthorizationHeaderHelperSync(BearerTokenAuthenticationPolicy.java:183)
        at com.azure.core.http.policy.BearerTokenAuthenticationPolicy.setAuthorizationHeaderSync(BearerTokenAuthenticationPolicy.java:169)
        at com.azure.security.keyvault.secrets.implementation.KeyVaultCredentialPolicy.authorizeRequestSync(KeyVaultCredentialPolicy.java:227)
        at com.azure.core.http.policy.BearerTokenAuthenticationPolicy.processSync(BearerTokenAuthenticationPolicy.java:131)
        at com.azure.core.http.HttpPipelineNextSyncPolicy.processSync(HttpPipelineNextSyncPolicy.java:41)
        at com.azure.core.http.policy.RetryPolicy.attemptSync(RetryPolicy.java:164)
        at com.azure.core.http.policy.RetryPolicy.attemptSync(RetryPolicy.java:176)
        at com.azure.core.http.policy.RetryPolicy.attemptSync(RetryPolicy.java:176)
        at com.azure.core.http.policy.RetryPolicy.attemptSync(RetryPolicy.java:176)
        at com.azure.core.http.policy.RetryPolicy.processSync(RetryPolicy.java:114)
        at com.azure.core.http.HttpPipelineNextSyncPolicy.processSync(HttpPipelineNextSyncPolicy.java:41)
        at com.azure.core.http.policy.HttpPipelineSyncPolicy.processSync(HttpPipelineSyncPolicy.java:42)
        at com.azure.core.http.policy.UserAgentPolicy.processSync(UserAgentPolicy.java:153)
        at com.azure.core.http.HttpPipelineNextSyncPolicy.processSync(HttpPipelineNextSyncPolicy.java:41)
        at com.azure.core.http.HttpPipeline.sendSync(HttpPipeline.java:131)
        at com.azure.core.implementation.http.rest.SyncRestProxy.send(SyncRestProxy.java:54)
        at com.azure.core.implementation.http.rest.SyncRestProxy.invoke(SyncRestProxy.java:75)
        at com.azure.core.implementation.http.rest.RestProxyBase.invoke(RestProxyBase.java:109)
        at com.azure.core.http.rest.RestProxy.invoke(RestProxy.java:91)
        at jdk.proxy2/jdk.proxy2.$Proxy3.getSecret(Unknown Source)
        at com.azure.security.keyvault.secrets.implementation.SecretClientImpl.getSecretWithResponse(SecretClientImpl.java:538)
        at com.azure.security.keyvault.secrets.SecretClient.getSecretWithResponse(SecretClient.java:229)
        at com.azure.security.keyvault.secrets.SecretClient.getSecret(SecretClient.java:171)
        at org.example.AzureCliAuthExample.main(AzureCliAuthExample.java:22)

To Reproduce

  1. Replace the url of the vault and the secret name within AzureCliAuthExample.java
    with legitimate values.
  2. Use ./gradlew run to start the app
  3. Error should be output about having an unupgraded version Azure CLI which causes the app to crash.

Code Snippet

See https://github.com/joshblackmoor/azure-sdk-cli-bug

Expected behaviour
Standard auth flow to work in the usual way.

Setup (please complete the following information):

  • OS: MacOS
  • IDE: IntelliJ
  • Library/Libraries: com.azure:azure-identity:1.9.2
  • Java version: 17
  • App Server/Environment: Run using the gradle wrapper e.g. ./gradlew run

Information Checklist
Kindly make sure that you have added all the following information above and checkoff the required fields otherwise we will treat the issuer as an incomplete report

  • Bug Description Added
  • Repro Steps Added
  • Setup information Added

Activity

  1. github-actions
    added
    Azure.Coreazure-core
    ClientThis issue points to a problem in the data-plane of the library.
    customer-reportedIssues that are reported by GitHub users external to the Azure organization.
    needs-team-triageWorkflow: This issue needs the team to triage.
    questionThe issue doesn't require a change to the product in order to be resolved. Most issues start as that
    on Aug 9, 2023
  2. github-project-automation
    added this to Java SDKs Azure Coreon Aug 9, 2023
  3. Josh Free (joshfree)
    added
    Azure.Identity
    and removed
    Azure.Coreazure-core
    on Aug 9, 2023
  4. Josh Free (joshfree)
    added this to Azure Identity SDK Improvements and removed this from Java SDKs Azure Coreon Aug 9, 2023
  5. Josh Free (joshfree)
    assigned
    Vinay Gera (g2vinay)
    on Aug 9, 2023

  6. joshfree commented on Aug 9, 2023

    @joshfree
    Josh Free (joshfree)
    on Aug 9, 2023
    Member

    Vinay Gera (@g2vinay) could you please investigate?

  7. furnivall commented on Aug 9, 2023

    @furnivall
    Danny Furnivall (furnivall)
    on Aug 9, 2023

    If it helps, an analogous issue was also found on the Python SDK earlier this week. @joshblackmoor and myself worked on both. To save you duplicating effort:
    Initial issue:
    Azure/azure-sdk-for-python#31493
    PR
    Azure/azure-sdk-for-python#31534

  8. Josh Free (joshfree)
    added
    bugThis issue requires a change to an existing behavior in the product in order to be resolved.
    and removed
    questionThe issue doesn't require a change to the product in order to be resolved. Most issues start as that
    on Aug 9, 2023

  9. g2vinay commented on Aug 10, 2023

    @g2vinay
    Vinay Gera (g2vinay)
    on Aug 10, 2023
    Member

    @joshblackmoor Danny Furnivall (@furnivall)

    Thank you for reporting this issue.
    I am investigating it and will provide updates here as we make the fix.

  10. Josh Free (joshfree)
    removed
    needs-team-triageWorkflow: This issue needs the team to triage.
    on Aug 10, 2023
  11. github-actions
    added
    needs-team-attentionWorkflow: This issue needs attention from Azure service team or SDK team
    on Aug 10, 2023
  12. Josh Free (joshfree)
    modified the milestones: 2023-10, 2023-09 on Aug 14, 2023
  13. Josh Free (joshfree)
    moved this to Planned in Azure Identity SDK Improvementson Aug 14, 2023
  14. Josh Free (joshfree)
    moved this from Not Started to In Progress in Azure Identity SDK Improvementson Aug 28, 2023
  15. Vinay Gera (g2vinay)
    modified the milestones: 2023-09, 2023-10 on Sep 6, 2023
  16. Vinay Gera (g2vinay)
    closed this as completedin #36553on Oct 16, 2023
  17. github-project-automation
    moved this from In Progress to Done in Azure Identity SDK Improvementson Oct 16, 2023

  18. g2vinay commented on Oct 16, 2023

    @g2vinay
    Vinay Gera (g2vinay)
    on Oct 16, 2023
    Member

    Fix for this is merged and will be released in the beta release this month and GA in Nov 2023.

  19. github-actions
    locked and limited conversation to collaborators on Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Azure.IdentityClientThis issue points to a problem in the data-plane of the library.bugThis issue requires a change to an existing behavior in the product in order to be resolved.customer-reportedIssues that are reported by GitHub users external to the Azure organization.needs-team-attentionWorkflow: This issue needs attention from Azure service team or SDK team

Type

No type

Projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions