Skip to content

Dispatch Checks + Use new mypy check in CI - #42831

Merged
Scott Beddall (scbedd) merged 17 commits into
mainfrom
dispatch-checks
Sep 8, 2025
Merged

Scott Beddall (scbedd) merged 17 commits into
mainfrom
dispatch-checks

Conversation

@scbedd

@scbedd Scott Beddall (scbedd) commented Sep 3, 2025 •

Copy link
Copy Markdown
Member

This PR:

  • Adds new script entrypoint eng/scripts/dispatch_checks.py which will be very similar to dispatch_tox, but simplified and meant to supplant only the features we really need.
  • Swaps our mypy utilization to use our new checks system
  • Filter out checks that are disabled BEFORE invoking them and possibly spinning an isolated venv
  • Ensure we pass the --isolate argument to each call within CI
  • Test negative case (add a mypy failure) See this build on a branch with an introduced mypy error

todo:

What this PR does NOT do is enforce the verbosity for the shellouts that are being done. There will be more followups on that in #42862

jenny (@JennyPng)

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new dispatch checks system by adding a new script eng/scripts/dispatch_checks.py that provides a simplified alternative to the existing dispatch_tox functionality. The script enables concurrent execution of multiple checks across packages using asyncio for improved performance.

Key changes:

  • Implements a new async-based check dispatch system with configurable concurrency
  • Provides structured output capture and summarization for check results
  • Includes comprehensive argument parsing for CI integration and developer workflows

Comment thread eng/scripts/dispatch_checks.py Outdated
Comment thread eng/scripts/dispatch_checks.py Outdated
@scbedd Scott Beddall (scbedd) moved this from 🤔 Triage to 🐝 Dev in Azure SDK EngSys 🚀🌒🧑‍🚀 Sep 3, 2025
@scbedd Scott Beddall (scbedd) moved this from 🐝 Dev to 🔬 Dev in PR in Azure SDK EngSys 🚀🌒🧑‍🚀 Sep 3, 2025
@scbedd Scott Beddall (scbedd) changed the title Dispatch Checks + Swap mypy usage Dispatch Checks + Use new mypy check in CI Sep 5, 2025
Comment thread eng/scripts/dispatch_checks.py
Comment thread eng/scripts/dispatch_checks.py Outdated
Comment thread eng/scripts/dispatch_checks.py Outdated
Comment thread eng/scripts/dispatch_checks.py Outdated
Comment thread eng/scripts/dispatch_checks.py
Comment thread eng/scripts/dispatch_checks.py Outdated
Co-authored-by: McCoy Patiño <39780829+mccoyp@users.noreply.github.com>
@scbedd
Scott Beddall (scbedd) merged commit b87b4ac into main Sep 8, 2025
26 of 34 checks passed
@scbedd
Scott Beddall (scbedd) deleted the dispatch-checks branch September 8, 2025 19:10
@kurtzeborn Scott K (kurtzeborn) moved this from 🔬 Dev in PR to 🎊 Closed in Azure SDK EngSys 🚀🌒🧑‍🚀 Sep 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

4 participants