fix relationship exception on dab validate - #2100
Merged
Sean Leonard (seantleonard) merged 8 commits intoMar 25, 2024
Merged
Conversation
added 2 commits
February 16, 2024 12:21
Abhishek Kumar (abhishekkumams)
requested review from
Aniruddh Munde (Aniruddh25),
Jelte Fennema-Nio (JelteF),
Mathieu Tremblay (Mathos1432),
aaronburtle,
Aaron Powell (aaronpowell),
Ayush Agarwal (ayush3797),
Gledis Zeneli (gledis69),
Bhaskar Mallapragada (mbhaskar),
neeraj-sharma2592,
Ravi Shetye (ravishetye),
rohkhann,
Sean Leonard (seantleonard),
Shyam Sundar J (severussundar),
Sourabh Jain (sourabh1007) and
tarazou9
as code owners
March 13, 2024 15:49
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
aaronburtle
reviewed
Mar 19, 2024
aaronburtle
reviewed
Mar 19, 2024
aaronburtle
reviewed
Mar 19, 2024
Sean Leonard (seantleonard)
left a comment
Sean Leonard (seantleonard)
left a comment
Contributor
There was a problem hiding this comment.
some feedback for making error messages a little clearer
Abhishek Kumar (abhishekkumams)
requested review from
aaronburtle and
Sean Leonard (seantleonard)
March 22, 2024 10:03
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Sean Leonard (seantleonard)
approved these changes
Mar 22, 2024
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
aaronburtle
approved these changes
Mar 25, 2024
aaronburtle
left a comment
aaronburtle
left a comment
Contributor
There was a problem hiding this comment.
Looks good, thanks for addressing all comments so quickly and opening new issues when needed.
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Sean Leonard (seantleonard)
enabled auto-merge (squash)
March 25, 2024 20:38
Sean Leonard (seantleonard)
deleted the
dev/abhishekkuma/fix_relationship_exception_dab_validate
branch
March 25, 2024 21:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why make this change?
dab validatereturns an Unhandled Exception if a table definition is not inferred #2037What is this change?
dab validatetries to collect all the exception, so some part of code might be triggered which was excepting some values. This PR addresses that and put more conservative approach to some of the code we have, by adding null checks and try/catch block.How was this tested?