Expose scale of CachedNetworkImageProvider on CachedNetworkImage - #576
Merged
Conversation
amake
force-pushed
the
feature/expose-scale
branch
from
March 30, 2021 07:27
8954fc5 to
e2d8ee6
Compare
Contributor
Author
|
It looks like the CI failure is not related to my changes:
|
amake
force-pushed
the
feature/expose-scale
branch
from
September 3, 2021 11:49
e2d8ee6 to
636db53
Compare
Contributor
Author
|
I've resolved the conflicts. |
|
Please merge this PR, really useful! |
|
One use case could be to use it with a seamless image pattern and repeat option, in order to scale the pattern. |
|
Any plan to merge this? |
amake
force-pushed
the
feature/expose-scale
branch
from
September 25, 2023 22:30
636db53 to
b44c05b
Compare
Contributor
Author
|
I've resolved the conflicts again. |
Contributor
Author
|
This test failure appears to be spurious. |
|
If you don't plan to merge this PR, could you at least tell why and close it? |
martijn00
approved these changes
Jul 31, 2024
martijn00
force-pushed
the
feature/expose-scale
branch
2 times, most recently
from
July 31, 2024 16:34
21fd20b to
2e82902
Compare
martijn00
force-pushed
the
feature/expose-scale
branch
from
July 31, 2024 17:21
2e82902 to
57854a6
Compare
amake
added a commit
to amake/orgro
that referenced
this pull request
Aug 17, 2024
abaj8494
pushed a commit
to abaj8494/orgro
that referenced
this pull request
Feb 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)
This PR exposes the
scaleargument ofCachedNetworkImageProviderin theCachedNetworkImageconstructor.Currently you cannot set the
scaleused by the implicitly instantiatedCachedNetworkImageProvider, so if you need to set the image scale then you have to use something likeImage(image: CachedNetworkImageProvider(url))so you can't take advantage of the various nice features ofCachedNetworkImage.🆕 What is the new behavior (if this is a feature change)?
Now you can pass the
scaleargument.💥 Does this PR introduce a breaking change?
No. The argument has the same default as
CachedNetworkImageProviderso the behavior is unchanged if not supplied.🐛 Recommendations for testing
Try supplying different values of
scaletoCachedNetworkImageand ensure they take effect.📝 Links to relevant issues/docs
#572
🤔 Checklist before submitting