Skip to content
This repository was archived by the owner on May 12, 2026. It is now read-only.

Disable dragging an image to MarkdownPreview and fix the behavior of an image dropped on CodeEditor.#298

Merged
asmsuechan merged 2 commits into
BoostIO:masterfrom
asmsuechan:fix-drop-an-image-on-CodeEditor-and-MarkdownPreview
Mar 8, 2017
Merged

Disable dragging an image to MarkdownPreview and fix the behavior of an image dropped on CodeEditor.#298
asmsuechan merged 2 commits into
BoostIO:masterfrom
asmsuechan:fix-drop-an-image-on-CodeEditor-and-MarkdownPreview

Conversation

@asmsuechan

Copy link
Copy Markdown
Contributor

Disable dragging an image to MarkdownPreview

f9d80bfce658e2e22edeec15e36bd624

And I fixed the behavior of an image dropped to CodeEditor. Please pay attention to the position of the cursor. Even I drop an image to the bottom of CodeEditor, it is pasted at the position of the cursor.

8e805523e0b8aa7bc935f0332d017880

@asmsuechan

asmsuechan commented Feb 20, 2017

Copy link
Copy Markdown
Contributor Author

It may duplicate: https://github.com/BoostIO/Boostnote/blob/master/browser/main/index.js#L17:L24 However, it occurs by handleImageDrop in CodeEditor.js. Perhaps it robs the event.

@profi248

Copy link
Copy Markdown
Contributor

With this code for insertion, it isn't working for me at all, and with no errors in console
demo

@asmsuechan

asmsuechan commented Feb 20, 2017

Copy link
Copy Markdown
Contributor Author

@kostaldavid8 Umm... Please give me more information (e.g. OS, BN version). I expect it happens due to the order of loading events. Did you try this branch?

@profi248

Copy link
Copy Markdown
Contributor

@asmsuechan Clean clone from your branch and still not working. I have Linux Fedora 25.

@asmsuechan

asmsuechan commented Feb 21, 2017

Copy link
Copy Markdown
Contributor Author

@kostaldavid8 Thx for informing. Perhaps it doesn't happen almost environments, I've confirmed mac/windows/ubuntu. Thus the priority of fixing it on Fedora is low, I'd like to prioritize usability on others. I'm so sorry for any inconveniences.

@asmsuechan asmsuechan merged commit 68bc440 into BoostIO:master Mar 8, 2017
@asmsuechan asmsuechan deleted the fix-drop-an-image-on-CodeEditor-and-MarkdownPreview branch March 8, 2017 06:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants