Skip to content
This repository was archived by the owner on May 12, 2026. It is now read-only.

Fixed InfoPanel layout in Trash#768

Merged
asmsuechan merged 3 commits into
masterfrom
fix-infoPanel-layout-in-trash
Aug 10, 2017
Merged

Fixed InfoPanel layout in Trash#768
asmsuechan merged 3 commits into
masterfrom
fix-infoPanel-layout-in-trash

Conversation

@kazup01

@kazup01 kazup01 commented Aug 6, 2017

Copy link
Copy Markdown
Member

White

screen shot 0029-08-06 at 12 58 22 pm

Dark

screen shot 0029-08-06 at 12 58 46 pm

refs: #765

@BoostnoteBot

Copy link
Copy Markdown
Collaborator

Please make sure to be pasted screenshots of all your changes.

@BoostnoteBot

Copy link
Copy Markdown
Collaborator

Be sure to be changed browser/main/Detail/SnippetNoteDetail.js.

@kazup01 kazup01 added the UI label Aug 6, 2017
@kazup01 kazup01 requested a review from asmsuechan August 6, 2017 03:59
@asmsuechan

Copy link
Copy Markdown
Contributor

InfoPanelTrashed Umm 🤔

@asmsuechan

Copy link
Copy Markdown
Contributor

I'll refactor this later because this PR contains important change regarding #765.

Comment thread browser/main/Detail/InfoPanelTrashed.js Outdated
Folder
</div>
<div styleName='group-section-control'>
<text>in Trash</text>{folderName}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer Trash than in Trash in this case.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed!

@asmsuechan asmsuechan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙆

@asmsuechan asmsuechan merged commit 9eaa90c into master Aug 10, 2017
@asmsuechan asmsuechan deleted the fix-infoPanel-layout-in-trash branch August 10, 2017 07:52
@kazup01

kazup01 commented Aug 10, 2017

Copy link
Copy Markdown
Member Author

Thanks!

@kazup01 kazup01 mentioned this pull request Aug 10, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants