Skip to content

[FIX] Make header respect -lf for the webvtt encoder - #1134

Merged
cfsmp3 merged 4 commits into
CCExtractor:masterfrom
NilsIrl:newline
Dec 9, 2019
Merged

[FIX] Make header respect -lf for the webvtt encoder#1134
cfsmp3 merged 4 commits into
CCExtractor:masterfrom
NilsIrl:newline

Conversation

@NilsIrl

@NilsIrl NilsIrl commented Dec 5, 2019

Copy link
Copy Markdown
Contributor
  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.
  • I have mentioned this change in the changelog.
  • I have never used CCExtractor.

See title

cfsmp3
cfsmp3 reviewed Dec 5, 2019
View reviewed changes
Comment thread src/lib_ccx/ccx_encoders_webvtt.c Outdated
@ccextractor-bot

ccextractor-bot commented Dec 5, 2019 •
edited
Loading

Copy link
Copy Markdown
Collaborator

CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results:

Report Name Tests Passed
Broken 13/13
DVB 5/7
DVR-MS 2/2
General 27/27
Hauppage 3/3
MP4 2/3
NoCC 10/10
Teletext 21/21
WTV 13/13
XDS 33/34
CEA-708 14/14
DVD 3/3
Options 46/86

It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you).

Your PR breaks these cases:


Check the result page for more info.

@ccextractor-bot

ccextractor-bot commented Dec 5, 2019 •
edited
Loading

Copy link
Copy Markdown
Collaborator

CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results:

Report Name Tests Passed
Broken 13/13
DVB 4/7
DVR-MS 2/2
General 27/27
Hauppage 3/3
MP4 3/3
NoCC 10/10
Teletext 21/21
WTV 13/13
XDS 34/34
CEA-708 14/14
DVD 3/3
Options 85/86

It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you).

Your PR breaks these cases:


Check the result page for more info.

@cfsmp3
cfsmp3 merged commit df66746 into CCExtractor:master Dec 9, 2019
@NilsIrl
NilsIrl deleted the newline branch January 10, 2020 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cfsmp3 cfsmp3 cfsmp3 left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@NilsIrl @ccextractor-bot @cfsmp3