Skip to content

[FEATURE] Simple MacOS GUI - #1138

Merged
cfsmp3 merged 15 commits into
CCExtractor:masterfrom
sampoder:master
Jan 19, 2020
Merged

[FEATURE] Simple MacOS GUI#1138
cfsmp3 merged 15 commits into
CCExtractor:masterfrom
sampoder:master

Conversation

@sampoder

@sampoder sampoder commented Dec 7, 2019

Copy link
Copy Markdown
Contributor
  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

My familiarity with the project is as follows (check one):

  • I have used CCExtractor just a couple of times.

I have created a simple GUI for MacOS. It was generated using the open-source Platypus tool created by Sveinbjörn Þórðarson after I saw a blog post about it and felt it would help CCExtractor.

The reason I feel that this feature should be added is because the command line can be complex for some people. A simple GUI like this is perfect for these people as all they have to do it drag in a file. However, for more advanced users, they can still use the command line. I have tried to make the install process as simple as possible

Maybe if there is interest in a more advanced GUI I can try and custom develop one.

@ccextractor-bot

ccextractor-bot commented Dec 7, 2019

Copy link
Copy Markdown
Collaborator

CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results:

Report Name Tests Passed
Broken 12/13
DVB 3/7
DVR-MS 2/2
General 27/27
Hauppage 3/3
MP4 3/3
NoCC 10/10
Teletext 14/21
WTV 13/13
XDS 34/34
CEA-708 14/14
DVD 3/3
Options 86/86

It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you).

Your PR breaks these cases:


Check the result page for more info.

@ccextractor-bot

ccextractor-bot commented Dec 7, 2019

Copy link
Copy Markdown
Collaborator

CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results:

Report Name Tests Passed
Broken 12/13
DVB 3/7
DVR-MS 2/2
General 27/27
Hauppage 3/3
MP4 2/3
NoCC 10/10
Teletext 21/21
WTV 13/13
XDS 34/34
CEA-708 14/14
DVD 3/3
Options 54/86

It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you).

Your PR breaks these cases:


Check the result page for more info.

@canihavesomecoffee

Copy link
Copy Markdown
Member

@cfsmp3 Any thoughts?

@MatejMecka Can you check this?

@cfsmp3

cfsmp3 commented Dec 31, 2019

Copy link
Copy Markdown
Contributor

I don't have a Mac handy - @MatejMecka ?

@MatejMecka

MatejMecka commented Dec 31, 2019 via email

Copy link
Copy Markdown
Contributor

@MatejMecka

Copy link
Copy Markdown
Contributor

Currently the Implementation is Simple as the GUI states but There should be a helpful log or maybe a loading indicator or alert when CCExtractor finishes. I got lost for a second being unsure if it worked or not, since previously I had not set up ccextractor at /usr/local/ and when i dumped the video button i didn't notice anything happening

@sampoder

sampoder commented Jan 1, 2020

Copy link
Copy Markdown
Contributor Author

I'm not able to Google Code In anymore this year for personal reasons :( but I'll have a go fixing this

@canihavesomecoffee

Copy link
Copy Markdown
Member

I'm not able to Google Code In anymore this year for personal reasons :( but I'll have a go fixing this

That'd be great 👍

@sampoder

sampoder commented Jan 1, 2020

Copy link
Copy Markdown
Contributor Author

I added an alert when the process is complete

@cfsmp3

cfsmp3 commented Jan 18, 2020

Copy link
Copy Markdown
Contributor

@sampoder what's the current status of this? Maybe we should close this PR until you're ready to come back?

@sampoder

Copy link
Copy Markdown
Contributor Author

@cfsmp3 I made the requested changes in the two most recent commits

@cfsmp3
cfsmp3 merged commit c69d2db into CCExtractor:master Jan 19, 2020
@cfsmp3

cfsmp3 commented Jan 19, 2020

Copy link
Copy Markdown
Contributor

Merged but @MatejMecka feel free to test more and comment :-)

@NilsIrl

NilsIrl commented Jan 19, 2020

Copy link
Copy Markdown
Contributor

Is it normal that so many binary files are included?

@MatejMecka

Copy link
Copy Markdown
Contributor

Those are standard MacOS files :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants