Skip to content

[IMPROVEMENT] Removed redundant check_configuration_file function - #1153

Merged
cfsmp3 merged 2 commits into
CCExtractor:masterfrom
MarcusGaiusPompey:redundant_function
Dec 22, 2019
Merged

[IMPROVEMENT] Removed redundant check_configuration_file function#1153
cfsmp3 merged 2 commits into
CCExtractor:masterfrom
MarcusGaiusPompey:redundant_function

Conversation

@MarcusGaiusPompey

Copy link
Copy Markdown
Contributor

Please prefix your pull request with one of the following: [FEATURE] [FIX] [IMPROVEMENT].

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.
  • I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

The check_configuration_file function takes in a dereferenced ccx_s_options struct as api_options, and calls parse_configuration by taking a reference to api_options . However, the only call to check_configuration_file is made by dereferencing a ccx_s_options struct, meaning parse_configuration can be called directly. Hence, there is no use for check_configuration_file, meaning it can be safely deleted.

@ccextractor-bot

Copy link
Copy Markdown
Collaborator

CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results:

Report Name Tests Passed
Broken 12/13
DVB 3/7
DVR-MS 2/2
General 27/27
Hauppage 3/3
MP4 3/3
NoCC 10/10
Teletext 14/21
WTV 13/13
XDS 34/34
CEA-708 14/14
DVD 3/3
Options 86/86

It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you).

Your PR breaks these cases:


Check the result page for more info.

@ccextractor-bot

Copy link
Copy Markdown
Collaborator

CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results:

Report Name Tests Passed
Broken 12/13
DVB 3/7
DVR-MS 2/2
General 27/27
Hauppage 3/3
MP4 3/3
NoCC 10/10
Teletext 21/21
WTV 13/13
XDS 34/34
CEA-708 14/14
DVD 3/3
Options 85/86

It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you).

Your PR breaks these cases:

  • ccextractor -out=sami -latin1 -autoprogram 5b4e0a6034...
  • ccextractor -datapid 5603 -autoprogram -out=srt -latin1 -teletext 85c7fc1ad7...
  • ccextractor -autoprogram -out=srt -latin1 85271be4d2...
  • ccextractor --capfile /repository/Dictionary/MattS_dictionary.txt c83f765c66...
  • ccextractor -stdout -quiet -nofc -nodvbcolor 79a51f3500...
  • ccextractor -stdout -quiet -nofc -nodvbcolor 767b546f96...

Check the result page for more info.

@cfsmp3
cfsmp3 merged commit 9cfc345 into CCExtractor:master Dec 22, 2019
@MarcusGaiusPompey
MarcusGaiusPompey deleted the redundant_function branch December 22, 2019 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants