Skip to content

[FIX] Added underline support for -out=spupng with EIA608/teletext - #1157

Merged
cfsmp3 merged 5 commits into
CCExtractor:masterfrom
jshin313:master
Dec 26, 2019
Merged

[FIX] Added underline support for -out=spupng with EIA608/teletext#1157
cfsmp3 merged 5 commits into
CCExtractor:masterfrom
jshin313:master

Conversation

@jshin313

@jshin313 jshin313 commented Dec 26, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.
  • I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

I added underline support to finish up the issue addressed here (#892) as part of a Google Code-in task.

@jshin313 jshin313 changed the title [Fix] Added underline support [Fix] Added underline support for -out=spupng with EIA608/teletext Dec 26, 2019
@jshin313 jshin313 changed the title [Fix] Added underline support for -out=spupng with EIA608/teletext [FIX] Added underline support for -out=spupng with EIA608/teletext Dec 26, 2019
@ccextractor-bot

ccextractor-bot commented Dec 26, 2019 •
edited
Loading

Copy link
Copy Markdown
Collaborator

CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results:

Report Name Tests Passed
Broken 12/13
DVB 3/7
DVR-MS 2/2
General 27/27
Hauppage 3/3
MP4 3/3
NoCC 10/10
Teletext 14/21
WTV 13/13
XDS 34/34
CEA-708 14/14
DVD 3/3
Options 86/86

It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you).

Your PR breaks these cases:


Check the result page for more info.

@ccextractor-bot

ccextractor-bot commented Dec 26, 2019 •
edited
Loading

Copy link
Copy Markdown
Collaborator

CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results:

Report Name Tests Passed
Broken 12/13
DVB 3/7
DVR-MS 2/2
General 26/27
Hauppage 3/3
MP4 2/3
NoCC 10/10
Teletext 21/21
WTV 13/13
XDS 28/34
CEA-708 0/14
DVD 0/3
Options 0/86

It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you).

Your PR breaks these cases:


Check the result page for more info.

@cfsmp3
cfsmp3 merged commit 6d07492 into CCExtractor:master Dec 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jshin313 @ccextractor-bot @cfsmp3