Repository navigation
Conversation
…heck On an in-repo feature PR, the `pull_request` run of ci.yml skips the `required-check` job because the push run owns the status. A skipped job still posts a check run under its name, and GitHub treats a skipped required check as satisfied. The push run's real mirror is only created once `ci` finishes, so for the whole test window the only check named `✅ Required PR Check` on the head SHA was the skipped one — the ruleset (and auto-merge) let the PR merge while tests were still running, gated only by CodeQL. Seen on CLDMV/slothlet#553. Give the job a conditional name: the real name on the paths that run, `⏭️ Required PR Check (reported by the push run)` on the skipped path, so the required check stays pending until the push run reports. Applied to the consumer template and to this repo's local-ci.yml.
…heck (#346) ## 🚀 What's Changed ### 💥 Breaking Changes _No breaking changes_ ### ✨ Features _No new features_ ### 🐛 Bug Fixes - fix(ci): stop the skipped PR-run mirror from satisfying Required PR Check (#346) (6bcf11d) ### 📦 Dependencies _No dependency updates_ ### 🔧 Other Changes - docs(ci): note that a skipped job's expression name is shown unevaluated (#346) (f8dcf5a) <details> <summary>👥 Contributors</summary> - @Shinrai </details>
cldmv-bot
Bot
added
! release → master
Shinrai
approved these changes
Oct 2, 2026
Shinrai
enabled auto-merge (squash)
October 2, 2026 20:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 What's Changed
💥 Breaking Changes
No breaking changes
✨ Features
No new features
🐛 Bug Fixes
📦 Dependencies
No dependency updates
🔧 Other Changes
👥 Contributors
Co-authored-by: Shinrai Shinrai@users.noreply.github.com