Skip to content

Feature/init forecast#572

Closed
zeliest wants to merge 2 commits into
developfrom
feature/init_forecast
Closed

Feature/init forecast#572
zeliest wants to merge 2 commits into
developfrom
feature/init_forecast

Conversation

@zeliest

@zeliest zeliest commented Oct 27, 2022

Copy link
Copy Markdown
Collaborator

Changes proposed in this PR:

  • Update init in forecast class

This PR fixes issue #

PR Author Checklist

PR Reviewer Checklist

@chahank
chahank requested a review from peanutfun October 28, 2022 11:46
@peanutfun

Copy link
Copy Markdown
Member

Forecast already has a meaningful constructor. This PR also contains a lot of unrelated whitespace changes. I would prefer to close it in favor of a PR that only updates the type hints for the __init__ method.

@peanutfun peanutfun closed this Oct 28, 2022
@peanutfun

Copy link
Copy Markdown
Member

See #574

@emanuel-schmid
emanuel-schmid deleted the feature/init_forecast branch December 12, 2022 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants