Autoplay #126

Activity

1. Mottie commented on Jul 1, 2011

   

   Mottie

   on Jul 1, 2011

   Contributor

   More actions

   The autoPlayLocked shouldn't be set to true if you have autoPlay set to false. I can force autoPlayLocked to be false internally when autoPlay is false but then you have less control over the slider. So is this a problem?
2. chrissly commented on Jul 1, 2011

   

   chrissly

   on Jul 1, 2011

   Author

   More actions

   Well, i guess its no big deal. I just depended on the autoPlay description "this turns off the entire Functionality" and was surprised, as i saw this.
   When having parameters, which can be independently set, but actually depend on each other, an internal consistency check would make sense for me. After all, it doesnt really take away functionality, but makes the system more reliable.
3. Mottie commented on Jul 1, 2011

   

   Mottie

   on Jul 1, 2011

   Contributor

   More actions

   Cool.. I was going to fix it anyway... darn OCD LOL.
4. Mottie commented on Jul 5, 2011

   

   Mottie

   on Jul 5, 2011

   Contributor

   More actions

   Hi Chrissly!

   Ok I've actually split out the autoPlay functionality and added buildStartStop like you suggested in another issue. And autoPlayLocked should no longer work when buildStartStop is false.
5. Mottie

   closed this as completedon Jul 6, 2011
6. Mottie commented on Jul 7, 2011

   

   Mottie

   on Jul 7, 2011

   Contributor

   More actions

   Hmmm, ok alternate method... I think Helmer has a good point about removing the autoPlay dependancy on the buildStartStop option.

   So I separated them and made the autoPlayLocked option false when autoPlay is false - I think that makes more sense.

   I just thought I'd let you know about the upcoming change :P
7. chrissly commented on Jul 14, 2011

   

   chrissly

   on Jul 14, 2011

   Author

   More actions

   Makes more sense, thats true;)