Question about line of code. #476

Activity

1. Mottie commented on Jan 5, 2013

   

   Mottie

   on Jan 5, 2013

   Contributor

   More actions

   Hmm, that looks like a mistake. The height should be cleared on the base.$wrapper before checking the base.$outer width. This was an attempt to prevent the slider from constantly expanding in height (when the expand option is true) when placed directly inside of the document body. Either way, if the height is set in the css, it shouldn't effect the height of the wrapper.

   I'll double check that the fix I mentioned will work and update the repository.

   Edit: After a bit of testing, it doesn't seem to make any difference with or without that bit of code. I'll go ahead and remove it because it is effecting elements outside the scope of the slider.
2. Mottie

   closed this as completedin b925534on Jan 5, 2013