initialized function problem #92

Activity

1. prootrash commented on Aug 27, 2012

   

   prootrash

   on Aug 27, 2012

   Author

   More actions

   I placed lines:

   base.initialized = true;
   base.$el.trigger( 'initialized.movingBoxes', [ base, base.curPanel ] );

   outside:

   base.change(base.curPanel, function(){
   
   }

   and now everything working very well...

   My modification:

   setTimeout(function(){
                   base.update(false);
                   base.initialized = true;
                   base.$el.trigger( 'initialized.movingBoxes', [ base, base.curPanel ] );
   
                   base.change(base.curPanel, function(){
                       // do nothing :P
                   }, false);
               }, o.speed * 2 );
2. Mottie commented on Aug 29, 2012

   

   Mottie

   on Aug 29, 2012

   Contributor

   More actions

   Thanks for taking the time to figure out the problem and working out a fix, but the two lines were within the change callback because of triggered events showing up before the plugin was initialized. I'll look into fixing this when I have some more time.

   Thanks!
3. visualjazz-snolan commented on Sep 4, 2012

   

   visualjazz-snolan

   on Sep 4, 2012

   More actions

   The code has a race condition in which the update call within the window load handler (line 60) kills the the animation call on line 356 (the animation complete function triggers the initialized event).

   Moving the setTimeout code to under the update function will fix the issue like below.

   $(window).load(function(){ // animate height after all images load
       base.update();
   
       // animate to chosen start panel - starting from the first panel makes it look better
       setTimeout(function(){
           base.change(base.curPanel, function(){
               base.initialized = true;
               base.$el.trigger( 'initialized.movingBoxes', [ base, base.curPanel ] );
           });
       }, o.speed * 2 );               
   });
4. Mottie commented on Sep 5, 2012

   

   Mottie

   on Sep 5, 2012

   Contributor

   More actions

   @visualjazz-snolan Thanks! I'll try to get this fixed in the next update (not sure when I'll get a chance, sorry).
5. Mottie commented on Sep 18, 2012

   

   Mottie

   on Sep 18, 2012

   Contributor

   More actions

   Fixed in version 2.3. I ended up including some code to check when all images are loaded instead of using window load.
6. Mottie

   closed this as completedon Oct 9, 2012