fix: 修复录制收尾、结果校验与跨平台回归 - #2
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
录制中关闭 Windows 窗口曾直接退出进程,留下只有 44 字节、缺少 moov 的 MP4;基础版还会在编码器未打开时报告保存成功。本 PR 修复这些数据完整性问题,并补齐区域选择、录制时基与 macOS 故障处理回归。
改动
验证
当前提交
9db6435的 四项 CI 全部通过:Ubuntu 3.11/3.12、macOS 3.12、Windows 3.12;各平台 lint 均通过。Windows / Python 3.12.10,PATH 提供 ffmpeg/ffprobe:
python -m pytest -q -rs→ 145 passed, 4 skipped。跳过 3 条真实硬件用例和 1 条仅适用于 POSIX SIGTERM 的 macOS 收尾用例。python -m flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics→ 0;git diff --check通过。两个 Windows GUI 均用模拟屏幕和真实 VideoWriter 验证:关闭后 MP4 可播放;Pro 验证颜色正确且录制时长误差不超过一帧。另覆盖收尾期间 GUI 响应、重复停止、合并失败、音频写入失败和区域选择生命周期。
此前被误判的六小时合成 MP4 现通过 macOS 容器校验;启动器的虚拟环境与失败退出路径已在临时目录验证。
尚未重新进行真实桌面、摄像头、麦克风权限和长时间硬件音画同步验收;本 PR 不发布新 Release。