test: add Pest v1 security test infrastructure - #27
Draft
somethingwithproof wants to merge 6 commits into
Draft
Conversation
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a Pest v1-based test scaffold intended to enforce security-related invariants (prepared statement usage, PHP 7.4 compatibility, and plugin setup.php structure) and introduces GitHub security automation config.
Changes:
- Add Pest bootstrap/config and new “Security” tests that scan plugin sources for specific patterns.
- Add
composer.jsonwith Pest v1 as a dev dependency to run the new test suite. - Add CodeQL and Dependabot configuration under
.github/.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
tests/Security/SetupStructureTest.php |
Adds a structure test for setup.php plugin hook functions and version metadata. |
tests/Security/PreparedStatementConsistencyTest.php |
Adds a source-scan test intended to prevent reintroduction of raw DB helper calls. |
tests/Security/Php74CompatibilityTest.php |
Adds source-scan tests to block common PHP 8.0-only constructs/usages. |
tests/Pest.php |
Pest entrypoint that loads the test bootstrap. |
tests/bootstrap.php |
Stubs Cacti framework functions/constants for isolated test loading. |
composer.json |
Introduces Composer dev setup with Pest dependency and test bootstrap autoloading. |
.github/workflows/codeql.yml |
Adds a CodeQL workflow (currently configured for JS/TS only, with PHP ignored for triggers). |
.github/dependabot.yml |
Adds Dependabot config (currently includes npm updates). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
somethingwithproof
marked this pull request as draft
April 11, 2026 00:09
Member
Author
|
Converted to draft to serialize the stack in this repo. Blocked by #23; will un-draft after that merges to avoid cross-PR merge conflicts. |
Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
Add source-scan tests verifying security patterns (prepared statements, output escaping, auth guards, PHP 7.4 compatibility) remain in place across refactors. Tests run with Pest v1 (PHP 7.3+) and stub the Cacti framework so plugins can be tested in isolation. Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
…dabot - Throw RuntimeException when realpath/file_get_contents fails (previously silent continue hid unscanned files) - Fix Dependabot ecosystem from npm to composer - Remove committed .omc session artifacts, add .omc/ to .gitignore Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
somethingwithproof
force-pushed
the
test/add-security-test-infrastructure
branch
from
August 24, 2026 00:21
39f1f50 to
9dbc9fd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
composer install && vendor/bin/pestpasses