Skip to content

Twitter cards/image unfurls don't work in PR previews #77

Description

@ljdursi

When Cloudflare does a preview on a local branch, it renders the page at a URL like https://f707160d.candig-github-io.pages.dev. Relative URLs for new images and resources in the branch will work, but absolute URLs won't.

That works for most things (e.g. new blog posts) but not for image unfurls (e.g. what you get as a preview of a page when you post the link into slack or twitter). That's because the Jekyll template creates absolute URLs. https://github.com/CanDIG/candig.github.io/blob/production/_includes/head.html#L50. We should try getting rid of that prefixing and see if (a) it breaks any existing posts and (b) if it works for new branches so we can test the unfurling ahead of time before publishing.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions