Bugfix/427 back button doesnt work when activity launched#429
Merged
Canato merged 10 commits intoAug 29, 2022
Merged
Conversation
On Cancelled Result will no longer show empty screen
Canato
approved these changes
Aug 29, 2022
|
@Canato When will be new version updated with these fixes. |
|
@Canato Thanks for the instant release of the new version with fixes. |
Member
|
Ohh my message yesterday didn't whent! But thanks for the reminder. We need to find a way to automate snapshot generations until we do a release. @devpathare |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #427
Bug:
Clicking back on a screen that shows an alert dialog with
CameraandGallerywould do nothing.Cause:
The dialog is non dismiss-able so the back button is is ignored.
Reproduce
Open the crop image screen which shows the non dismiss-able alert dialog with the options
CameraandGallery.Click back and nothing happens.
How the bug was solved:
Added an OnKeyListener to the non dismiss-able alert dialog to detect back key pressed. On back key detected the onBackPressed is triggered.
Also fixed the issue where on cancelling/pressing back when intending not to edit/crop the image it would open a screen with an empty image view.