Bugfix/437 setting toolbar color to white does nothing#438
Merged
Canato merged 14 commits intoSep 26, 2022
Merged
Conversation
…s and toolbar back button color
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -239,6 +264,19 @@ open class CropImageActivity : | |||
| ) | |||
Check warning
Code scanning / detekt
Caught exception is too generic. Prefer catching specific exceptions to the case that is currently handled.
Check warning
Code scanning / detekt
Caught exception is too generic. Prefer catching specific exceptions to the case that is currently handled.
Canato
approved these changes
Sep 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #437
Added customizations to toolbar colors [New Feature]
Description:
Users can not customize toolbar colors of back button, title and menu texts.
Check list for the Code Reviewer:
Fixed and issue where setting white color to toolbar would do nothing [Bug]
Bug
Setting white color as the toolbar color would do nothing
Cause:
A default of -1 was used as the toolbar color which conflicted with the value of
Color.WHITEin the android source code. So when we checked if Color.WHITE i.e. -1 was set this would assume that no color was set to the toolbar.Reproduce
Set toolbar color to
Color.WHITE.This should set the toolbar color to white.
But the toolbar will remain the original color i.e. the primary color set in the styles which is currently Purple.
How the bug was solved:
Set the default color to null instead of -1.