Kotlin Build Script, proper Maven Publishing, new workflows, Gradle Catalogue & much more#450
Merged
Conversation
Contributor
Author
|
@Canato so my proposal would be:
Then the real work can start |
Canato
approved these changes
Oct 19, 2022
Canato
left a comment
Canato
left a comment
Member
There was a problem hiding this comment.
LGTM ^^
Love the snapshot releases, was missing this
Contributor
Author
|
Yeah let's hope I configured everything correctly 🤞 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've tried this out in my project (by publishing into maven local):
I've also set up my credentials here: https://github.com/CanHub/Android-Image-Cropper/settings/secrets/actions
I copied most of the configs from either https://github.com/vanniktech/Emoji or https://github.com/vanniktech/blurhash
@Canato when merging this a snapshot version would automatically be uploaded using my coordinates. A new release would be done pushing a git tag, CI should do all of the releasing. I'd generate the changelogs using https://github.com/github-changelog-generator/github-changelog-generator
Feels a bit wrong that this is listed under canhub and using my credentials 🤷 but for the time being this should be okay.