Fixed bug when changing toolbar text color

[Husseinhj]

I find an issue that happens in order to change the activityMenuTextColor color and if you disabled other buttons from the toolbar like the flip menu, you will get a crash because the menu is null.

This code snippet will cause a crash if you use it:

CropImageOptions().apply {
    allowFlipping = false
    activityMenuTextColor = getColor(R.color.purple)
}

Crash log

java.lang.NullPointerException: Attempt to invoke interface method 'java.lang.CharSequence android.view.MenuItem.getTitle()' on a null object reference
   at com.canhub.cropper.CropImageActivity.updateMenuItemTextColor(CropImageActivity.kt:454)
   at com.canhub.cropper.CropImageActivity.onCreateOptionsMenu(CropImageActivity.kt:288)
   at android.app.Activity.onCreatePanelMenu(Activity.java:3373)
   at androidx.activity.ComponentActivity.onCreatePanelMenu(ComponentActivity.java:521)
   at androidx.fragment.app.FragmentActivity.onCreatePanelMenu(FragmentActivity.java:287)
   at androidx.appcompat.view.WindowCallbackWrapper.onCreatePanelMenu(WindowCallbackWrapper.java:95)
   at androidx.appcompat.app.AppCompatDelegateImpl$AppCompatWindowCallback.onCreatePanelMenu(AppCompatDelegateImpl.java:3122)
   at androidx.appcompat.app.AppCompatDelegateImpl.preparePanel(AppCompatDelegateImpl.java:1913)
   at androidx.appcompat.app.AppCompatDelegateImpl.doInvalidatePanelMenu(AppCompatDelegateImpl.java:2194)
   at androidx.appcompat.app.AppCompatDelegateImpl$2.run(AppCompatDelegateImpl.java:276)
   at android.os.Handler.handleCallback(Handler.java:789)
   at android.os.Handler.dispatchMessage(Handler.java:98)
   at android.os.Looper.loop(Looper.java:164)
   at android.app.ActivityThread.main(ActivityThread.java:6541)
   at java.lang.reflect.Method.invoke(Native Method)
   at com.android.internal.os.Zygote$MethodAndArgsCaller.run(Zygote.java:240)
   at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:767)

[vanniktech]

Thanks!

[haliltprkk]

Hello guys, is this fix released ?

[nick-sasquatch]

I'm also interested in using this functionality-- @vanniktech is this going to be released soon? Thanks!

[lepicekmichal]

Still crashing