Skip to content
This repository was archived by the owner on May 7, 2026. It is now read-only.

chore(trino): upgrade testcontainers to 4.7.2 - #689

Merged
grieve54706 merged 1 commit into
mainfrom
feature/ibis/upgrade-testcontainers
Jul 24, 2024
Merged

grieve54706 merged 1 commit into
mainfrom
feature/ibis/upgrade-testcontainers

Conversation

@grieve54706

@grieve54706 grieve54706 commented Jul 23, 2024 •

Copy link
Copy Markdown
Contributor

Upgrade testcontainers and use the TrinoContainer of testcontainers instead of the container we made.

Relate testcontainers/testcontainers-python#642

@goldmedal goldmedal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @grieve54706 looks nice. Just one question.
BTW, I think you can link this PR to your PR in testcontainers repo. https://github.com/testcontainers/testcontainers-python/pull/642/files

Comment on lines +166 to +167
user=(info.user and info.user.get_secret_value()),
password=(info.password and info.password.get_secret_value()),

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curiously, why need to have an and operation here? For null checking? If yes, should we do the same thing for other properties?

@grieve54706 grieve54706 Jul 24, 2024 •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, for None. Other information about the data source is not allowed to be none.

upgrade testcontainers and use the TrinoContainer of testcontainers instead of the container we made
@grieve54706
grieve54706 force-pushed the feature/ibis/upgrade-testcontainers branch from 1d2f6d4 to aee1fca Compare July 24, 2024 03:02
@grieve54706
grieve54706 merged commit 971da4c into main Jul 24, 2024
@grieve54706
grieve54706 deleted the feature/ibis/upgrade-testcontainers branch July 24, 2024 03:26
grieve54706 added a commit that referenced this pull request Dec 13, 2024
upgrade testcontainers and use the TrinoContainer of testcontainers instead of the container we made
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants