This repository was archived by the owner on May 7, 2026. It is now read-only.
Repository navigation
chore(trino): upgrade testcontainers to 4.7.2 - #689
Merged
Merged
Conversation
goldmedal
approved these changes
Jul 24, 2024
goldmedal
left a comment
Contributor
There was a problem hiding this comment.
Thanks @grieve54706 looks nice. Just one question.
BTW, I think you can link this PR to your PR in testcontainers repo. https://github.com/testcontainers/testcontainers-python/pull/642/files
Comment on lines
+166
to
+167
| user=(info.user and info.user.get_secret_value()), | ||
| password=(info.password and info.password.get_secret_value()), |
Contributor
There was a problem hiding this comment.
Curiously, why need to have an and operation here? For null checking? If yes, should we do the same thing for other properties?
Contributor
Author
There was a problem hiding this comment.
Yes, for None. Other information about the data source is not allowed to be none.
upgrade testcontainers and use the TrinoContainer of testcontainers instead of the container we made
grieve54706
force-pushed
the
feature/ibis/upgrade-testcontainers
branch
from
July 24, 2024 03:02
1d2f6d4 to
aee1fca
Compare
grieve54706
added a commit
that referenced
this pull request
Dec 13, 2024
upgrade testcontainers and use the TrinoContainer of testcontainers instead of the container we made
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade testcontainers and use the
TrinoContainerof testcontainers instead of the container we made.Relate testcontainers/testcontainers-python#642