fix: hide 'currently unavailable' rows when a dimension filter is active - #112
Merged
Conversation
Augmentation loop was firing on every variant - so on the rpc-capabilities
?chain=bnb tab, the 10 providers that don't ship a BNB endpoint were
showing up as 'Currently unavailable' rows even though they don't
compete on that chain at all. Same pattern would hit metadata-coverage
on solana, l1-finality on hedera, etc.
Only augment the unfiltered ('All') variant where a no-data result
genuinely means 'harness lost this provider'. On a filtered view a
no-data result means 'this provider doesn't cover this dimension',
which isn't a reliability story and shouldn't pollute the leaderboard.
Product pages keep their fallback because they aggregate across every
bench, not a single filtered view.
This was referenced Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug rapporté sur rpc-capabilities. Quand tu cliques un onglet chain (
?chain=bnbpar ex), les 10 providers qui ne supportent pas BNB s'affichent quand même comme 'Currently unavailable' — alors qu'ils ne sont pas censés competer sur cette chain. Pareil pour metadata-coverage sur solana, l1-finality sur hedera, etc.Fix : on n'augmente plus que la vue non-filtrée ('All'). Sur une vue filtrée, no-data = pas de couverture pour cette dimension, pas un story de fiabilité.