chart export v3: dimmer watermark + toBlob download path + unified button style - #1440
Merged
Conversation
Flotapponnier
added a commit
that referenced
this pull request
Jul 25, 2026
…taset item) (#1442) * chart export v3: dimmer watermark + toBlob download path + unified button style (#1440) * fix: Virtuals chain detection + update methodology text for Relay/Mobula * chart export v3: dimmer watermark, toBlob download path, unified Image/Video button style --------- Co-authored-by: Florent Tapponnier <contact@mobula.io> * jsonld: inline isBasedOn Dataset fields in StatisticalReport Rich Results Test on ws-head-latency-ethereum confirmed 3 Datasets detected (bench + isPartOf + isBasedOn) with one invalid. The mystery 3rd was the @id-only isBasedOn ref inside StatisticalReport. Same failure mode as isPartOf (already fixed in PR #1429): Google validates each Dataset in isolation and does not stitch @id refs even inside the same @graph. Inline the required fields (name, description, url, creator, license) on the isBasedOn ref so it validates on its own. Same pattern as isPartOf. --------- Co-authored-by: Florent Tapponnier <contact@mobula.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three follow-ups on the previous export ship.
Watermark dimmed
Download button fix
Switched capture from `toPng → fetch(dataURL) → blob()` to `toBlob` direct. Kills:
Image/Video buttons — same style as Copy/DL
Both had heavy dark-ink solid squares (`p-2.5 bg-ink`) — replaced with the same light border + shadow pill style + icon+label (`Image` / `Video`), matching the ChartExportButton visually. Now the four export controls (Copy, Download, Image, Video) look like a coherent toolbar.