Skip to content

perp-fees: delete gauges on asset_not_found (Lighter ghost metrics) #1620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Flotapponnier wants to merge 1 commit into from
Closed

perp-fees: delete gauges on asset_not_found (Lighter ghost metrics) #1620

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion harnesses/perp-fees/cmd/script/metrics.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,8 +121,24 @@ func init() {

func recordSample(s PerpSample) {
if s.Err != "" {
fetchErrorsCtr.WithLabelValues(s.Venue, s.Asset, classifyErr(s.Err)).Inc()
errType := classifyErr(s.Err)
fetchErrorsCtr.WithLabelValues(s.Venue, s.Asset, errType).Inc()
healthGauge.WithLabelValues(s.Venue, s.Asset).Set(0)
// Permanent failures (asset delisted, unsupported venue) must delete
// the gauge series so stale values don't persist as ghost metrics.
// Transient failures (timeout, rate limit, server error) intentionally
// keep the last good value so a brief outage doesn't blank the board.
if errType == "not_found" {
allInGauge.DeleteLabelValues(s.Venue, s.Asset)
spreadGauge.DeleteLabelValues(s.Venue, s.Asset)
takerFeeGauge.DeleteLabelValues(s.Venue, s.Asset)
fundingGauge.DeleteLabelValues(s.Venue, s.Asset)
fetchLatencyGauge.DeleteLabelValues(s.Venue, s.Asset)
lastRefreshGauge.DeleteLabelValues(s.Venue, s.Asset)
for _, n := range tierNotionals {
allInTierGauge.DeleteLabelValues(s.Venue, s.Asset, notionalLabel(n))
}
}
return
}
takerFeeGauge.WithLabelValues(s.Venue, s.Asset).Set(s.TakerFeeBps)
Expand All @@ -149,6 +165,8 @@ func recordSample(s PerpSample) {

func classifyErr(msg string) string {
switch {
case contains(msg, "asset_not_found") || contains(msg, "unsupported_venue"):
return "not_found"
case contains(msg, "timeout"):
return "timeout"
case contains(msg, "401") || contains(msg, "403"):
Expand Down
Loading