fix(pm): include resolved markets in Polymarket vol24h + remove Manifold from hub - #1659
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
closed=true&active=false&end_date_min=<25h_ago>markets. Markets that resolved during the day are excluded from theactive=truepass but still carryvolume24hr > 0from trades before resolution. The second pass (capped at 10 pages) captures their contribution and stops early when all rows show zero volume.PM_VENUESstops it from appearing in the cross-venue table and from inflating the "Total volume 30d" and "Active markets" summary cards. The harness continues collecting Manifold data; only the hub display changes.Test plan
/prediction-marketshub no longer shows a Manifold rowocb-pm-cohort-stats— look for[polymarket][polymarket] closed page=0log line confirming the second pass runsvol24hincreases compared to previous tick (should be materially higher once closed markets are included)