fix: bump all-benchmarks cache key to v6 - #185
Merged
Merged
Conversation
PR #184 added providersPerChain to Benchmark + bumped the inner bench-unfiltered cache key to v4, but missed the OUTER loadAllBenchmarks cache (`all-benchmarks-v5`). The aggregate cache can keep serving v5-era Benchmark slices (no providersPerChain) even after the per-bench cache is fresh, leaving /products/[slug] showing phantom chips for chain-restricted providers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completes the cache-key bump from #184. The inner per-bench cache moved to v4 but the outer all-benchmarks aggregate cache stayed at v5 → /products pages kept reading benchmark slices without providersPerChain → phantom chain chips persisted.