Skip to content

fix(chart): top-N selector hidden on metrics with sparse data #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Flotapponnier merged 1 commit into from
Jun 2, 2026
Merged

fix(chart): top-N selector hidden on metrics with sparse data #258

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions src/components/time-series-chart.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,10 +138,16 @@ export function TimeSeriesChart({
return built;
}, [benchmark, range, region, colors, excluded, seriesOverride]);

// Top-N selector. When the cohort grows past ~20 series the chart
// becomes visually noisy and the legend wraps to multiple lines.
// null = show all; number = clip to the top N by recent mean.
const TOP_N_DEFAULT = allLines.length > 20 ? 20 : null;
// Top-N selector. Sized off the REGISTERED cohort, not the subset
// that happened to emit data this cycle. On the headline metric some
// providers can return empty series for legitimate reasons (zero
// activity in the window, fresh registry entry not yet backfilled by
// Prom), but the reader still has a 60 row cohort and wants the
// filter affordance — sizing off `allLines` would hide the selector
// for exactly the views where it matters most. The slice itself
// operates on `allLines` so empty providers stay out of the chart.
const cohortSize = benchmark.results.length;
const TOP_N_DEFAULT = cohortSize > 20 ? 20 : null;
const [topN, setTopN] = useState<number | null>(TOP_N_DEFAULT);
const lines = useMemo(() => {
if (topN == null) return allLines;
Expand Down Expand Up @@ -262,7 +268,7 @@ export function TimeSeriesChart({
</div>
)}

{allLines.length > 10 && (
{cohortSize > 10 && (
<div className="flex items-center gap-1">
<span className="mr-2 text-[10px] uppercase tracking-[0.16em] text-ink-faint">
Show
Expand Down
Loading