hotfix(bench-body): fix JSX parse error from PR #273 - #275
Closed
Flotapponnier wants to merge 2 commits into
Closed
Conversation
Re-greped each export in src/lib against the rest of src/. Deletes (0 references confirmed): - leaderForChain() in citation.ts — defined when per-chain headline rewrites were planned, never wired up. - fmtCount() in live/format.ts — fmtCountFull is what ticker.tsx uses; the short variant has no callers. Tightened visibility (only used inside the defining file): - AlternativeWithBench (alternatives.ts) export -> internal type - stripFaqMarkdown (jsonld.ts) export -> internal helper - chainIdFragment (jsonld.ts) export -> internal helper pnpm exec tsc --noEmit --noUnusedLocals --noUnusedParameters: EXIT=0 pnpm build: green.
Collaborator
Author
|
Closing as part of branch/PR cleanup |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
PR #273 was merged with broken JSX. My perl edit dropped the
${activePanel.label}template interpolation AND the closing}on the ledger title ternary. Vercel staging build failed with "Parsing ecmascript source code failed at line 388:14". Dev is currently un-deploying.Fix
Reformats the ternary back to a multi-line form with the template literal restored and the closing brace present.
Test plan