fix(bench): resolve {{}} placeholders on overlay fast path - #571
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: bench pages (FAQ, abstract, seo_intro, findings, disclaimer, per_chain_explainer) rendered literal {{p50:geckoterminal}} / {{name:slug}} tokens instead of the live values.
Root cause: overlayEditorial in spec.ts copies the raw YAML editorial fields onto the stored benchmark without running them through renderTemplate. Three call sites (lines 111, 270, 333) all hit this path. The materialise-worker path DOES call renderBenchmarkText, so a freshly materialised snapshot rendered correctly, but the fast overlay path (used when a YAML edit ships ahead of the next materialise sweep) leaked the raw tokens.
Fix: have overlayEditorial run its output through renderBenchmarkText before returning. Single line change downstream of the three call sites = single source of truth for editorial template resolution. Tests still pass (87/87). Type + lint clean.
Affects every bench page on the site. After deploy, FAQ + seo_intro + disclaimer + abstract + findings + per_chain explainer all read correctly substituted across aggregator-head-lag and every other bench.