Skip to content

hotfix(citation): drop sampleSize===0 from isInsufficient predicate #630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Flotapponnier merged 1 commit into from
Jun 22, 2026
Merged

hotfix(citation): drop sampleSize===0 from isInsufficient predicate #630

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/lib/citation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,12 @@ import { fmtUnit } from "@/lib/format";
export function isInsufficient(b: Benchmark): boolean {
if (b.editorialStatus !== "live") return true;
if (b.status !== "live") return true;
if (b.sampleSize === 0) return true;
// Note: do NOT key on b.sampleSize === 0. The aggregator loader can
// fall back to a draft placeholder with sampleSize=0 even when the
// per-bench loader holds real data, which mass-flagged 25 of 26
// benches as insufficient on /api/citable while /api/stat returned
// live values for the same slug. The liveResults length and p50
// finiteness checks below already catch the genuine empty case.
const live = liveResults(b.results);
if (live.length === 0) return true;
return live.every((r) => !Number.isFinite(r.ms.p50) || r.ms.p50 <= 0);
Expand Down
Loading