hotfix(build): loadBenchmark safe-fallback + HF Space short_description - #654
Merged
Conversation
…HF Space description Two fixes bundled because both must land for the next prod-deploy to succeed. loadBenchmark fell back to loadAllBenchmarks (strict) when the per-slug cache miss happened. The strict aggregator throws AllBenchmarksDraftError when the quorum guard from #631 trips, which crashes next build during any Prom blackout. Both fallback sites now use loadAllBenchmarksSafe, which substitutes draft placeholders for the same blackout. Behavior at runtime is unchanged when Prom is healthy. HF Space short_description was 86 chars, HF rejects anything > 60. Shortened to 46.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes bundled because both block the next prod-deploy.
Build crash on Prom blackout
loadBenchmarkfalls back toloadAllBenchmarks(strict) on per-slug cache miss. The strict aggregator throwsAllBenchmarksDraftErrorwhen the quorum guard from #631 trips. Anynext buildduring a Prom blackout was crashing (the latest #651 build hit this).Both fallback sites in
spec.tsnow useloadAllBenchmarksSafe, which catches the throw and substitutes draft placeholders. Runtime behavior when Prom is healthy is unchanged.HF Space deploy
short_descriptioninscripts/hf_space/README.mdwas 86 chars, HF rejects anything > 60. Shortened to 46.Tests
bun test src/lib/spec.test.ts15/15 pass.pnpm typecheckclean.