Skip to content

fix(template) + header redesign (CMC-style + sub-nav) - #677

Merged
Flotapponnier merged 2 commits into
devfrom
feat/header-search-bar
Jun 24, 2026
Merged

fix(template) + header redesign (CMC-style + sub-nav)#677
Flotapponnier merged 2 commits into
devfrom
feat/header-search-bar

Conversation

@Flotapponnier

Copy link
Copy Markdown
Collaborator

Summary

Follow-up to PR #671 (already merged). Two unrelated fixes on the same branch:

1. Template leak fix

  • `{{best_name}}` / `{{best_p50}}` were leaking onto bench pages.
  • `renderBenchmarkText` now also resolves `seoTitle`, `seoDescription`, `subtitle`, `methodology`, `disclaimer` (only `abstract` / `findings` / `seoIntro` / `faq` / `perChainExplainer` were covered before).
  • Chain stash lookup is case-insensitive: perp-fees declares `dimensions.chain` as `ETH` / `BTC` / `SOL` (uppercase) so `{{best_p50:chain:BTC}}` previously fell through.
  • Bumped cache keys `bench-unfiltered v12→v13` + `all-benchmarks v16→v17` so prod regenerates.

2. Header redesign (CMC-style)

  • Removed the `|` separator between Contribute and GitHub.
  • Active-section underline (accent color) under the current tab.
  • 15px nav, taller bar (h-16 desktop), backdrop-blur on the sticky.
  • GitHub icon-only, gap-spaced utilities, no pipe.
  • New `SiteSubNav`: category tabs on `/benchmarks*` (All / Aggregators / Bridges / Blockchains / Trading / RPCs / Wallets / NFT APIs), hidden on other sections. Horizontal scroll on mobile with edge-fade mask.

Test plan

  • Visit `/benchmarks/aggregator-head-lag` → no raw `{{best_name}}` in DOM, meta description, or view-source.
  • Visit `/benchmarks/perp-fees/btc` → per-chain explainer renders the resolved value.
  • Header: navigate Benchmarks → Products → About → confirm underline follows the active tab.
  • Sub-nav: on `/benchmarks`, category tabs visible; on `/about`, no sub-nav strip.
  • Mobile: hamburger menu still works; sub-nav scrolls horizontally with fade hint.

- renderBenchmarkText now covers seoTitle, seoDescription, subtitle,
  methodology, disclaimer. Raw tokens were leaking into RSC props +
  /api/citable consumers.
- chain stash lookup is case-insensitive: perp-fees YAML uses uppercase
  asset codes (ETH/BTC/SOL) so {{best_p50:chain:BTC}} previously fell
  through.
- bumped bench-unfiltered v12->v13 and all-benchmarks v16->v17 so prod
  cached entries regenerate.
- remove the | separator between Contribute and GitHub
- active-section underline (accent color) under the current tab,
  matched via usePathname so /benchmarks/<slug> highlights Benchmarks
- nav links bumped to 15px, taller header (h-16 desktop) for breathing
- right utilities: search + github (icon-only) + theme, gap-spaced
- backdrop-blur on the sticky bar so content scrolling under it stays
  legible without the harsh opaque white
- new SiteSubNav: category tabs on /benchmarks*, hidden elsewhere.
  Horizontal scroll on mobile with edge-fade mask hint.
@Flotapponnier
Flotapponnier force-pushed the feat/header-search-bar branch from d6eed46 to 4cf519e Compare June 24, 2026 13:22
@Flotapponnier
Flotapponnier merged commit b790011 into dev Jun 24, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant