redesign search dialog (no accent ring, cleaner rows) - #682
Merged
Conversation
- Drop the global accent outline on the cmdk input (was reading as a
validation error, not a focus state). Universal :focus-visible rule
stays; we opt out only on [cmdk-input].
- Wider modal (max-w-2xl), softer border, deeper shadow, stronger
backdrop blur.
- Item rows: drop the bordered BENCHMARK pill (chunky/dated), use a
small uppercase kind label + middle-dot separator + title, with an
ArrowRight that lights up on the selected row.
- Footer with kbd hints (↑ ↓ navigate, ↵ open, esc close) replacing
the cramped 'ENTER TO GO / ESC TO CLOSE' microcaps.
- Search index: drop '{{best_name}}' tokens from descriptions. Fall
back to spec.subtitle when seo_description contains template tokens
(build-time index has no Prom data to resolve them).
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #680 — commit landed after the merge. Cleans up the search dialog itself (the modal that opens on click / Cmd+K) which the previous PRs left untouched.
Fixes
Redesign
Test plan