search: fix 'awaiting data' fallback + valid featured slugs - #688
Merged
Conversation
- Replace 'awaiting data' negative copy with skeleton (during fetch) or 'View leaderboard →' / category line (after fetch fails). Cards always read as complete. - Swap evm-quote-latency and solana-tx-landing-latency out of the featured list — they're not in /api/citable (editorialStatus filter). Replaced with perp-fees + bridge-quote-latency which return leader data on prod. Trending list also rotated to slugs verified against the live API. - Category label on each card sources from item.tags[0] (bench category) instead of hardcoded 'Benchmark', so the cards self-label as Trading / RPCs / Bridges / etc.
User feedback: category strip on /benchmarks was visual noise. Drop SiteSubNav entirely; nav stays a single row.
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the search dialog landed in PR #687 — some Live leaders cards showed "awaiting data" because their slugs weren't in /api/citable (editorialStatus filter excludes them).
Fixes
Test plan