Skip to content

fix(products): badge URLs use raw bench slug, not canonical product slug #760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Flotapponnier merged 1 commit into from
Jun 26, 2026
Merged

fix(products): badge URLs use raw bench slug, not canonical product slug #760

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions src/app/products/[slug]/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,7 @@ export default async function ProviderPage({
chain?: { value: string; label: string };
region?: { value: string; label: string };
benchSlug: string;
providerSlug: string;
};
const badgeCards: BadgeCard[] = [];
for (const a of sorted) {
Expand All @@ -162,6 +163,12 @@ export default async function ProviderPage({
const me = a.result.slug.toLowerCase();
const benchSlug = a.benchmark.slug;
const title = a.benchmark.title;
// The bench knows the provider under its raw slug (e.g.
// "publicnode-feehistory" on gas-estimation, "matic-usd" on
// oracle-deviation), while `p.slug` is the canonical product slug
// from the URL (publicnode, polygon). The badge route is keyed by
// the raw slug, so use that for badge URLs to avoid 404s.
const providerSlug = a.result.slug;

let handledByCells = false;
if (cellRanks && regionDims.length > 0) {
Expand All @@ -187,7 +194,7 @@ export default async function ProviderPage({
wonKeys.size === finestKeys.length &&
finestKeys.length === expectedCells
) {
badgeCards.push({ key: benchSlug, title, benchSlug });
badgeCards.push({ key: benchSlug, title, benchSlug, providerSlug });
continue;
}
if (wonKeys.size === 0) continue;
Expand All @@ -204,6 +211,7 @@ export default async function ProviderPage({
title,
chain: c,
benchSlug,
providerSlug,
});
for (const k of row) covered.add(k);
}
Expand All @@ -217,6 +225,7 @@ export default async function ProviderPage({
title,
region: r,
benchSlug,
providerSlug,
});
for (const k of col) covered.add(k);
}
Expand All @@ -231,6 +240,7 @@ export default async function ProviderPage({
...(chain ? { chain } : {}),
region,
benchSlug,
providerSlug,
});
}
continue;
Expand All @@ -243,14 +253,14 @@ export default async function ProviderPage({
const isGlobalNumberOne = a.rank === 1;
if (chainDims.length === 0) {
if (isGlobalNumberOne) {
badgeCards.push({ key: benchSlug, title, benchSlug });
badgeCards.push({ key: benchSlug, title, benchSlug, providerSlug });
}
continue;
}
const leadsAllChains =
chainDims.length > 0 && wonChains.length === chainDims.length;
if (isGlobalNumberOne && leadsAllChains) {
badgeCards.push({ key: benchSlug, title, benchSlug });
badgeCards.push({ key: benchSlug, title, benchSlug, providerSlug });
continue;
}
for (const c of wonChains) {
Expand All @@ -259,6 +269,7 @@ export default async function ProviderPage({
title,
chain: c,
benchSlug,
providerSlug,
});
}
}
Expand Down Expand Up @@ -661,7 +672,7 @@ export default async function ProviderPage({
if (card.chain) scopeParams.set("chain", card.chain.value);
if (card.region) scopeParams.set("region", card.region.value);
const qs = scopeParams.size > 0 ? `?${scopeParams.toString()}` : "";
const badgePath = `/api/badge/${card.benchSlug}/${p.slug}${qs}`;
const badgePath = `/api/badge/${card.benchSlug}/${card.providerSlug}${qs}`;
const badgeUrl = `${SITE.url}${badgePath}`;
const targetUrl = `${SITE.url}/benchmarks/${card.benchSlug}${qs}`;
const scopeSuffix = `${card.chain ? ` on ${card.chain.label}` : ""}${card.region ? ` from ${card.region.label}` : ""}`;
Expand Down
Loading