add Galera checks to mysql check plugin by gurubert · Pull Request #2 · Checkmk/checkmk

gurubert · 2019-05-02T16:10:49Z

This pull request adds some MySQL Galera checks.

No modification of the agent plugin is necessary as the required variables will be included if the MySQL instance is part of a Galera cluster.

gurubert · 2019-05-02T16:12:09Z

BTW: where do I find the comment formatter for the ASCII art?

LarsMichelsen · 2019-05-02T19:26:00Z

Use: doc/helpers/figheader BlaBla

si-23

Please yapf the check plugin file

Use readable strings; no internal strings If-block only checks the state, drag infotext out

gurubert · 2019-05-08T07:46:00Z

Please review again, the new commits should fix the issues.

…LWA, #2 - it script allows parameter - correctly joined path on developer machines - applied to missing files too Change-Id: I1fe571ed183aec520adac8954c9e7915859941e0

Change-Id: I9e7d831aff879df6e0c51d85978ff24d3207e600

si-23

Notes for next reviews:

Please rebase on master; the first changes are already done
Please yapf the file, otherwise formatter tests would fail
Transfer comments on the first sub galera check to other galera sub checks

I've fixed above comments and add your changes.

si-23 · 2019-07-30T13:39:21Z

+
+def inventory_mysql_galerasync(parsed):
+    for instance, values in parsed.iteritems():
+        if values.get('wsrep_provider', 'none') != 'none' and u'wsrep_local_state_comment' in values:


values.get('KEY') is not None

'get' returns None if key not found

use 'is' operator for checking agains object's identity ('==' to check equality)

I think this has been written that way because wsrep_provider may also return False if set and then the if does not eval correctly.

Sure it does:

`

d = {}
d['k'] = False
d.get('k', 'none') != 'none'
True
d.get('k') is not None
True
d.get('l', 'none') != 'none'
False
d.get('l') is not None
False
`

si-23 · 2019-07-30T13:40:14Z

+            state = 0
+        else:
+            state = 2
+        return (state, 'WSREP local state comment: %s' % values[u'wsrep_local_state_comment'])


Rewrite to:

wsrep_local_state_comment = data.get('wsrep_local_state_comment') if wsrep_local_state_comment is None: return if wsrep_local_state_comment == 'Synced': state = 0 else: state = 2 return state, 'WSREP local state comment: %s' % wsrep_local_state_comment

less indentation

one lookup instead of two

more readable

si-23 · 2019-07-30T13:41:17Z

+            yield instance, {}
+
+@get_parsed_item_data
+def check_mysql_galerasync(item, _no_params, values):


convention; rename: values => data
(decorator says "get parsed item DATA")

see commit 95d1f2e

si-23 · 2019-07-30T13:42:14Z

+        if values[u'wsrep_sst_donor'] == params['wsrep_sst_donor']:
+            return (0, 'WSREP sst donor contains "%s"' % values[u'wsrep_sst_donor'])
+        else:
+            return (1, 'WSREP sst donor contains "%s" and not "%s"' % (values[u'wsrep_sst_donor'], params['wsrep_sst_donor']))


levels/params should be placed in brackets as other checks do:
if state: infotext += " (was at discovery %s)"

see commit d9300d4

si-23 · 2019-07-30T13:43:48Z

+    "inventory_function"      : inventory_mysql_galerasync,
+    "check_function"          : check_mysql_galerasync,
+    "service_description"     : "MySQL Galera Sync %s",
+    "has_perfdata"            : False,


that's the default, can be removed

see commit 8437746

si-23 · 2019-07-30T13:52:16Z

The man pages are missing. Please deliver them in addition.

It is very hot in the office, sorry

si-23 · 2019-07-31T07:27:06Z

.. will be merged with werk 8824

Add the breadcrumb for all page types pages Change-Id: I1245df381a19e89ef8658a6c40def2d41c78ba12

CMK-5044 Change-Id: Ibce3e77c83c851a80214b650f416676d4b128856

…re closes sockets before stream.flush done during logging. Method #2 Change-Id: I2872a11257b17c4823e7651bab488def3ae53816

Change-Id: I75de9f36b738510927039df1d37233239bd51630

The validation of the plugin parameters in a ruleset took a lot of time since the lookups for the plugins of a ruleset were not optizimied. Now using a simple lookup table for this. Change-Id: Ie6043a353c48d27ad337801015d4d50df052a1d0

All files in agent/windows/plugins Change-Id: I1247ec8553303970ca6144f1d84af67194827d6c

Pass the stats with the payload. CMK-5909 Change-Id: Icf2c6a8691eda9b89d9cabe59abf9024d88ecd24

Removed check_maanger.get_check() --> moved to Check() Checks are loaded via "config_load_all_checks" fixture All tests from j-z Change-Id: I36abf53ce2bd7128291961e7d7ddda24607c3de1

* Add serializable data store that contains the information needed by every SNMP fetcher. CMK-5462 Change-Id: If776dc9e1b5a2cb5604cea3667de56473af01a87

Change-Id: I1f6da9b62e8ad6d910b61c70952f3e8c8bf34aa5

Change-Id: I3957af67acd000f98d163ad91baadf31aa465f98

Use VisualLinkSpec in more places. CMK-5654 Change-Id: I5427ba54510adf2acc62165013d3307ac771b674

Change-Id: Ib1e9d89976c74de99683206aa2a714b2776eed08

because SRP 😛 Now it is clear that the parser does not parse as much as it separates the piggybacked sections from the not-piggybacked ones. CMK-6516 Change-Id: I29746ad2063fb4bdbbd72dc87e74fc9c4d9ce21a

- set packaged type if check_mk.install.yml exists and [global][install] == "no" - extend few unit-tests Change-Id: I4141e337637333b1722fb9ab25a791bf00ee2ef1

The Checkmk GitHub repository has no Enterprise features. Thats why we can't test them in these unit tests. Change-Id: Ic2fad538d9f13d8477e06105dc673650df25fd96

- cfg.cpp #2 - remove strange .clang.tidy Change-Id: I9e45a48d4ad5e7f2462835812be77c05de0cc206

Additional change to Werk 11930. The link would only work if no host was determined. Now it works with host aswell. Change-Id: Icdda404451cc58991bb91f385cf792cd02799013

Change-Id: I4f01b3e3d884e78ae78390487e298fa03080183d

The shortcut menu now hides the title for an icon if configured. Change-Id: I4c085ead3c3dbde0e8f607663af765eb04e6eaf0

CMK-7076 Change-Id: I87aa0a873f272b066bc9ca40af1bdab08bd415b0

* We need an rsync *with* chown option (we knew that before...) * The need rpm was only moved... Change-Id: I0cb3de2ecc9e02600e868caa1b7fad60500aedce

add Galera checks to mysql check plugin

ed0623c

LarsMichelsen requested a review from si-23 May 3, 2019 07:26

si-23 reviewed May 3, 2019

View reviewed changes

gurubert and others added 5 commits May 7, 2019 22:20

fancy comments

3745672

missed one comment…

b596397

use iteritems() instead of items()

4fffad3

code cleanup

1a01553

Use readable strings; no internal strings If-block only checks the state, drag infotext out

now with @get_parsed_item_data decorator

97f04b9

gurubert mentioned this pull request May 8, 2019

Autodetection of galera check works HeinleinSupport/check_mk_extensions#45

Closed

svenpanne added enhancement New feature or request Component: Checks & Agents labels May 15, 2019

LarsMichelsen added a commit that referenced this pull request Jul 4, 2019

Cleanup after sp #2

165e823

Change-Id: I9e7d831aff879df6e0c51d85978ff24d3207e600

si-23 self-assigned this Jul 30, 2019

si-23 previously approved these changes Jul 30, 2019

View reviewed changes

si-23 closed this Jul 30, 2019

si-23 reopened this Jul 30, 2019

gurubert added 5 commits July 30, 2019 16:03

man pages

dddb5a1

Merge branch 'master' into mysql

cf0cff8

replaced values with data

95d1f2e

better wording

d9300d4

remove default has_perfdata

8437746

si-23 closed this Jul 31, 2019

LarsMichelsen added a commit that referenced this pull request Jul 15, 2020

Add breadcrumb to Configuration pages #2

88f7809

Add the breadcrumb for all page types pages Change-Id: I1245df381a19e89ef8658a6c40def2d41c78ba12

LarsMichelsen pushed a commit that referenced this pull request Jul 22, 2020

Configurator #2: cpu_tracking_utils

25bc6ea

CMK-5044 Change-Id: Ibce3e77c83c851a80214b650f416676d4b128856

LarsMichelsen pushed a commit that referenced this pull request Aug 19, 2020

[CMK-5072] - stop python process from generating exception if Microco…

d52c360

…re closes sockets before stream.flush done during logging. Method #2 Change-Id: I2872a11257b17c4823e7651bab488def3ae53816

LarsMichelsen pushed a commit that referenced this pull request Sep 17, 2020

Replace Check_MK by Checkmk in comments #2

0367d7c

Change-Id: I75de9f36b738510927039df1d37233239bd51630

LarsMichelsen pushed a commit that referenced this pull request Oct 6, 2020

Added Version to all agent plugins #2

e4114c4

All files in agent/windows/plugins Change-Id: I1247ec8553303970ca6144f1d84af67194827d6c

LarsMichelsen pushed a commit that referenced this pull request Oct 22, 2020

cpu_tracking: Pass stats with payload #2

64d52a9

Pass the stats with the payload. CMK-5909 Change-Id: Icf2c6a8691eda9b89d9cabe59abf9024d88ecd24

LarsMichelsen pushed a commit that referenced this pull request Oct 30, 2020

Lighter SNMP config #2

dbdcb6e

* Add serializable data store that contains the information needed by every SNMP fetcher. CMK-5462 Change-Id: If776dc9e1b5a2cb5604cea3667de56473af01a87

LarsMichelsen added a commit that referenced this pull request Nov 9, 2020

Refactor more modes to new confirm dialog #2

ffacbac

Change-Id: I1f6da9b62e8ad6d910b61c70952f3e8c8bf34aa5

LarsMichelsen added a commit that referenced this pull request Nov 9, 2020

Refactor html.confirm calls to new confirm dialog #2

961f192

Change-Id: I3957af67acd000f98d163ad91baadf31aa465f98

LarsMichelsen added a commit that referenced this pull request Nov 27, 2020

Prepare for view to dashboard linking #2

269cb7a

Use VisualLinkSpec in more places. CMK-5654 Change-Id: I5427ba54510adf2acc62165013d3307ac771b674

LarsMichelsen added a commit that referenced this pull request Dec 2, 2020

Add some diagnostic output to track down integration test problems #2

be104d7

Change-Id: Ib1e9d89976c74de99683206aa2a714b2776eed08

LarsMichelsen added a commit that referenced this pull request Dec 2, 2020

Add some diagnostic output to track down integration test problems #2

3798b0f

Change-Id: Ib1e9d89976c74de99683206aa2a714b2776eed08

LarsMichelsen pushed a commit that referenced this pull request Dec 4, 2020

Fix Travis CI #2

68fc2fb

The Checkmk GitHub repository has no Enterprise features. Thats why we can't test them in these unit tests. Change-Id: Ic2fad538d9f13d8477e06105dc673650df25fd96

LarsMichelsen pushed a commit that referenced this pull request Dec 18, 2020

[CMK-6766] - improve source code quality

36302ef

- cfg.cpp #2 - remove strange .clang.tidy Change-Id: I9e45a48d4ad5e7f2462835812be77c05de0cc206

LarsMichelsen pushed a commit that referenced this pull request Dec 18, 2020

[CMK-6766] - improve source code quality

cf80bb2

- cfg.cpp #2 - remove strange .clang.tidy Change-Id: I9e45a48d4ad5e7f2462835812be77c05de0cc206

LarsMichelsen pushed a commit that referenced this pull request Jan 26, 2021

Fix cmk = cmk -h #2

bdbe949

Change-Id: I4f01b3e3d884e78ae78390487e298fa03080183d

LarsMichelsen pushed a commit that referenced this pull request Jan 26, 2021

Fix cmk = cmk -h #2

978d4b4

Change-Id: I4f01b3e3d884e78ae78390487e298fa03080183d

LarsMichelsen pushed a commit that referenced this pull request Jan 28, 2021

Sidebar/Snapins: New Styling #2

ddf7724

The shortcut menu now hides the title for an icon if configured. Change-Id: I4c085ead3c3dbde0e8f607663af765eb04e6eaf0

LarsMichelsen pushed a commit that referenced this pull request Jan 28, 2021

Sidebar/Snapins: New Styling #2

2db5462

The shortcut menu now hides the title for an icon if configured. Change-Id: I4c085ead3c3dbde0e8f607663af765eb04e6eaf0

LarsMichelsen pushed a commit that referenced this pull request Feb 3, 2021

Simplify handling of pnp_graph_present #2 Nagios

3d7369d

CMK-7076 Change-Id: I87aa0a873f272b066bc9ca40af1bdab08bd415b0

LarsMichelsen pushed a commit that referenced this pull request Feb 3, 2021

Simplify handling of pnp_graph_present #2 Nagios

2fd14fe

CMK-7076 Change-Id: I87aa0a873f272b066bc9ca40af1bdab08bd415b0

LarsMichelsen pushed a commit that referenced this pull request May 4, 2021

Fix Centos-6 Container #2

15acfff

* We need an rsync *with* chown option (we knew that before...) * The need rpm was only moved... Change-Id: I0cb3de2ecc9e02600e868caa1b7fad60500aedce

lbuhleie mentioned this pull request Aug 21, 2026

Patched resolve_secret_option password_store API function to handle multiword arguments properly #947

Open

Uh oh!

Conversation

gurubert commented May 2, 2019

Uh oh!

gurubert commented May 2, 2019

Uh oh!

LarsMichelsen commented May 2, 2019

Uh oh!

si-23 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gurubert commented May 8, 2019

Uh oh!

si-23 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

si-23 Jul 30, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

si-23 commented Jul 30, 2019

Uh oh!

si-23 commented Jul 31, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

si-23 Jul 30, 2019 •

edited

Loading