Repository navigation
[Fusion] Stripe path segment pool per CPU core - #10025
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to reduce contention in Fusion’s JSON path-building by changing PathSegmentMemory from a single shared PathSegmentPool to a striped set of pools, intended to spread concurrent Rent/Return activity across multiple locks. It also updates repo ignores for local perf artifacts.
Changes:
- Replace the single global
PathSegmentPoolwith a stripe-per-worker selection mechanism and per-stripe pool initialization. - Add a
Reconfigureimplementation that recreates the striped pools via a factory. - Ignore
.perfartifacts via.gitignore.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/HotChocolate/Fusion/src/Fusion.Execution/Text/Json/PathSegmentMemory.cs | Introduces striped pool creation/selection and updates reconfiguration to work with multiple pools. |
| .gitignore | Adds .perf to ignored paths. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Patch coverage85.0% of changed lines covered (136/160)
Uncovered changed lines (JSON){
"sha": "a6c996d611c2a316e05d4a28cd1feeb86537805b",
"files": [
{ "path": "src/HotChocolate/Fusion/src/Fusion.Execution/Text/Json/PathSegmentPool.cs", "ranges": [[111, 112], [114, 116], [118, 120], [123, 123], [125, 128], [130, 131], [285, 285], [306, 307], [347, 348], [355, 356], [387, 388]] }
]
}Project coverage: 52.5% (217170/413351 lines) |
michaelstaib
added a commit
that referenced
this pull request
Jul 2, 2026
This was referenced Jul 7, 2026
This was referenced Jul 14, 2026
This was referenced Sep 7, 2026
Closed
This was referenced Sep 15, 2026
Closed
[nuget][SUI_Matcher]- Bump the sui-package-updates group with 20 updates
DFE-Digital/SUI_Matcher#405
Closed
This was referenced Sep 22, 2026
Closed
Closed
[nuget][SUI_Matcher]- Bump the sui-package-updates group with 20 updates
DFE-Digital/SUI_Matcher#410
Merged
This was referenced Oct 5, 2026
This was referenced Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.