Repository navigation
[Fusion] Fix flaky NATS broker dispose test race - #10046
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a race in the Fusion NATS subscription dispose test by ensuring an in-flight MoveNextAsync() is awaited (and observed) before the async enumerator is disposed, preventing illegal mid-MoveNextAsync disposal behavior.
Changes:
- Capture the in-flight
MoveNextAsync()task instead of fire-and-forget. - Dispose the broker and assert that the active subscription is canceled, avoiding disposing an async iterator while it is running.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced Jul 7, 2026
This was referenced Jul 14, 2026
This was referenced Jul 23, 2026
chore(deps): Bump HotChocolate.Subscriptions.InMemory from 15.1.14 to 16.5.1
Kuestenlogik/Bowire#506
Merged
This was referenced Sep 7, 2026
Closed
This was referenced Sep 15, 2026
Closed
[nuget][SUI_Matcher]- Bump the sui-package-updates group with 20 updates
DFE-Digital/SUI_Matcher#405
Closed
This was referenced Sep 22, 2026
Closed
Closed
[nuget][SUI_Matcher]- Bump the sui-package-updates group with 20 updates
DFE-Digital/SUI_Matcher#410
Merged
This was referenced Oct 5, 2026
This was referenced Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DisposeAsync_Should_DisposeBrokerConnection_When_BrokerIsDisposedstarted a fire-and-forgetMoveNextAsync()and then disposed the subscription enumerator while it was still pending. Disposing anIAsyncEnumeratormid-MoveNextAsyncis illegal, so the compiler-generated async iterator threwNotSupportedException("Specified method is not supported.") under CI threadpool contention.MoveNextAsyncis running, and block 1 gains a real assertion (it previously had none).Test plan
MoveNextAsync+DisposeAsync).