Repository navigation
Re-enable the point input test for a missing geometry type - #10350
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The change is a minimal, targeted test un-skip with no behavioral code changes, and the test expectation matches the now-correct null propagation behavior described in the PR metadata.
Pull request overview
This PR re-enables a previously skipped test case in the Spatial types test suite, now that the underlying input parsing behavior (missing nullable value-type fields remaining null) has been corrected by prior work.
Changes:
- Removes the
Skipmarker from theGeoJSONPointInput(PointInputName) inline-data case forParseLiteral_Should_Throw_When_NoGeometryType. - Ensures the test suite covers the “missing geometry type” failure path for both
PointInputNameandGeometryTypeName.
File summaries
| File | Description |
|---|---|
| src/HotChocolate/Spatial/test/Types.Tests/GeoJsonPointSerializerTests.cs | Re-enables the previously skipped PointInputName theory case so missing type now asserts the expected LeafCoercionException. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This was referenced Oct 25, 2026
Merged
This was referenced Nov 1, 2026
Closed
[nuget][SUI_Matcher]- Bump the sui-package-updates group with 21 updates
DFE-Digital/SUI_Matcher#424
Open
Bump HotChocolate.AspNetCore.Pipeline and HotChocolate.Fusion.AspNetCore
feddi-dev/feddi-gateway#109
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GeoJSONPointInputcase ofParseLiteral_Should_Throw_When_NoGeometryTypeinGeoJsonPointSerializerTests, which had been skipped with a review note since January 2023.typeintoPointand let the literal parse. Don't assume default value for optional value type argument without default value #8754 removed that fallback, so a missingtypenow reaches the serializer asnulland the expectedLeafCoercionExceptionis thrown.Test plan
HotChocolate.Types.Spatial.Testspasses on net10.0 with no skipped tests.