Skip to content

Re-enable the point input test for a missing geometry type - #10350

Merged
glen-84 merged 1 commit into
mainfrom
gai/unskip-point-input-missing-type-test
Sep 3, 2026
Merged

glen-84 merged 1 commit into
mainfrom
gai/unskip-point-input-missing-type-test

Conversation

@glen-84

@glen-84 glen-84 commented Sep 3, 2026

Copy link
Copy Markdown
Member

Summary

  • Re-enables the GeoJSONPointInput case of ParseLiteral_Should_Throw_When_NoGeometryType in GeoJsonPointSerializerTests, which had been skipped with a review note since January 2023.
  • The case failed because the input parser used to fill a missing nullable value-type field with the type's default value, which turned a missing type into Point and let the literal parse. Don't assume default value for optional value type argument without default value #8754 removed that fallback, so a missing type now reaches the serializer as null and the expected LeafCoercionException is thrown.

Test plan

  • HotChocolate.Types.Spatial.Tests passes on net10.0 with no skipped tests.

Copilot AI lite review requested due to automatic review settings September 3, 2026 15:03

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The change is a minimal, targeted test un-skip with no behavioral code changes, and the test expectation matches the now-correct null propagation behavior described in the PR metadata.

Pull request overview

This PR re-enables a previously skipped test case in the Spatial types test suite, now that the underlying input parsing behavior (missing nullable value-type fields remaining null) has been corrected by prior work.

Changes:

  • Removes the Skip marker from the GeoJSONPointInput (PointInputName) inline-data case for ParseLiteral_Should_Throw_When_NoGeometryType.
  • Ensures the test suite covers the “missing geometry type” failure path for both PointInputName and GeometryTypeName.
File summaries
File Description
src/HotChocolate/Spatial/test/Types.Tests/GeoJsonPointSerializerTests.cs Re-enables the previously skipped PointInputName theory case so missing type now asserts the expected LeafCoercionException.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@glen-84
glen-84 merged commit 2925892 into main Sep 3, 2026
152 checks passed
@glen-84
glen-84 deleted the gai/unskip-point-input-missing-type-test branch September 3, 2026 15:13
This was referenced Oct 25, 2026
This was referenced Nov 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants