Repository navigation
Simplify redundant type references in the Nitro CLI - #10411
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved issues were identified that would block approval.
Review effort: Lite
Findings: None
What changed in this PR
Simplifies redundant type references in Nitro CLI source and tests without changing behavior.
Changes:
- Removes the redundant generic type argument from
Array.AsReadOnly. - Simplifies JSON and mail message type references in tests.
| File | Description |
|---|---|
| src/Nitro/CommandLine/test/CommandLine.Tests/Commands/Agent/Tasks/ShowTaskCommandTests.cs | Updated as part of this pull request. |
| src/Nitro/CommandLine/test/CommandLine.Tests/Commands/Agent/Mail/ReadMailCommandTests.cs | Updated as part of this pull request. |
| src/Nitro/CommandLine/src/CommandLine/Services/Workspace/AgentRole.cs | Updated as part of this pull request. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Patch coverage0.0% of changed lines covered (0/1)
Uncovered changed lines (JSON){
"sha": "faa6ea6edd621458677264afa4b538701ffc558d",
"files": [
{ "path": "src/Nitro/CommandLine/src/CommandLine/Services/Workspace/AgentRole.cs", "ranges": [[15, 15]] }
]
}Project coverage: 58.1% (290939/500358 lines) |
Contributor
|
✅ Nitro CLI E2E snapshots: no flow recordings changed vs |
This was referenced Oct 25, 2026
Merged
This was referenced Nov 1, 2026
This was referenced Nov 2, 2026
Closed
[nuget][SUI_Matcher]- Bump the sui-package-updates group with 21 updates
DFE-Digital/SUI_Matcher#424
Closed
Bump HotChocolate.AspNetCore.Pipeline and HotChocolate.Fusion.AspNetCore
feddi-dev/feddi-gateway#109
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<string>type argument on theArray.AsReadOnlycall backingAgentRole.WellKnown, which the collection expression already infers, and theChilliCream.Nitro.CommandLine.Services.Mail.MailMessageandSystem.Text.Json.JsonDocumentqualifiers in two agent command test files.EnforceOnBuild.Never, soEnforceCodeStyleInBuilddoes not report them at any severity, which is why they survived the CI style gate. The IDE anddotnet format style --diagnostics IDE0001 IDE0002do report them.Test plan
dotnet build src/Nitro/CommandLine/Nitro.CommandLine.slnx -p:EnforceCodeStyleInBuild=true: clean across net8.0 through net11.0, with only the pre-existingASPDEPR004/ASPDEPR008obsoletion warnings inSystemBrowser.csandFusionRunCommand.cs.dotnet test src/Nitro/CommandLine/test/CommandLine.Tests --framework net10.0 --filter-class '*ReadMailCommandTests' --filter-class '*ShowTaskCommandTests': 23 passed, 0 failed, 0 skipped.