Repository navigation
Fix style errors in the Nitro CLI - #10439
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved issues were identified that would block approval.
Review effort: Lite
Findings: None
What changed in this PR
This PR fixes redundant C# style qualifiers in the Nitro CLI and simplifies Task.FromResult calls without changing behavior.
Changes:
- Simplifies generic inference in three test fakes.
- Removes redundant namespace qualifiers in tests and production code.
- Updates an XML documentation reference.
| File | Description |
|---|---|
| src/Nitro/CommandLine/test/CommandLine.Tests/Tui/Shell/FakeTaskStore.cs | Updated as part of this pull request. |
| src/Nitro/CommandLine/test/CommandLine.Tests/Tui/Agents/FakeMemoryStore.cs | Updated as part of this pull request. |
| src/Nitro/CommandLine/test/CommandLine.Tests/Tui/Agents/FakeMailStore.cs | Updated as part of this pull request. |
| src/Nitro/CommandLine/test/CommandLine.Tests/Commands/Agent/Mail/SendMailCommandTests.cs | Updated as part of this pull request. |
| src/Nitro/CommandLine/src/CommandLine/Tui/Mail/MailDetailView.cs | Updated as part of this pull request. |
| src/Nitro/CommandLine/src/CommandLine/Services/Notify/MailWakeDaemonCoordinator.cs | Updated as part of this pull request. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Patch coverage100.0% of changed lines covered (1/1)
Project coverage: 58.8% (298810/508055 lines) |
Contributor
|
✅ Nitro CLI E2E snapshots: no flow recordings changed vs |
This was referenced Oct 25, 2026
Merged
This was referenced Nov 1, 2026
This was referenced Nov 2, 2026
Closed
[nuget][SUI_Matcher]- Bump the sui-package-updates group with 21 updates
DFE-Digital/SUI_Matcher#424
Open
Bump HotChocolate.AspNetCore.Pipeline and HotChocolate.Fusion.AspNetCore
feddi-dev/feddi-gateway#109
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MailWakeDaemonCoordinator,MailDetailView, andSendMailCommandTests.Task.FromResultin theFakeMailStore,FakeMemoryStore, andFakeTaskStoretest fakes.Test plan
dotnet build src/Nitro/CommandLine/Nitro.CommandLine.slnxsucceeds.